Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1752703003: Fix transform feedback bugs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: set correct cached buffer in command buffer Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h" 5 #include "gpu/command_buffer/service/gles2_cmd_decoder.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 #include <stdio.h> 10 #include <stdio.h>
(...skipping 4519 matching lines...) Expand 10 before | Expand all | Expand 10 after
4530 glGenBuffersARB(1, &service_id); 4530 glGenBuffersARB(1, &service_id);
4531 CreateBuffer(client_id, service_id); 4531 CreateBuffer(client_id, service_id);
4532 buffer = GetBuffer(client_id); 4532 buffer = GetBuffer(client_id);
4533 } 4533 }
4534 } 4534 }
4535 LogClientServiceForInfo(buffer, client_id, "glBindBufferBase"); 4535 LogClientServiceForInfo(buffer, client_id, "glBindBufferBase");
4536 if (buffer) { 4536 if (buffer) {
4537 // TODO(kbr): track indexed bound buffers. 4537 // TODO(kbr): track indexed bound buffers.
4538 service_id = buffer->service_id(); 4538 service_id = buffer->service_id();
4539 } 4539 }
4540 state_.SetBoundBuffer(target, buffer);
Zhenyao Mo 2016/03/02 17:09:36 You will need to do all the validations before you
qiankun 2016/03/03 10:14:15 The validations have been done in client side. Do
4540 glBindBufferBase(target, index, service_id); 4541 glBindBufferBase(target, index, service_id);
4541 } 4542 }
4542 4543
4543 void GLES2DecoderImpl::DoBindBufferRange(GLenum target, GLuint index, 4544 void GLES2DecoderImpl::DoBindBufferRange(GLenum target, GLuint index,
4544 GLuint client_id, 4545 GLuint client_id,
4545 GLintptr offset, 4546 GLintptr offset,
4546 GLsizeiptr size) { 4547 GLsizeiptr size) {
4547 Buffer* buffer = NULL; 4548 Buffer* buffer = NULL;
4548 GLuint service_id = 0; 4549 GLuint service_id = 0;
4549 if (client_id != 0) { 4550 if (client_id != 0) {
(...skipping 11197 matching lines...) Expand 10 before | Expand all | Expand 10 after
15747 } 15748 }
15748 15749
15749 // Include the auto-generated part of this file. We split this because it means 15750 // Include the auto-generated part of this file. We split this because it means
15750 // we can easily edit the non-auto generated parts right here in this file 15751 // we can easily edit the non-auto generated parts right here in this file
15751 // instead of having to edit some template or the code generator. 15752 // instead of having to edit some template or the code generator.
15752 #include "base/macros.h" 15753 #include "base/macros.h"
15753 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h" 15754 #include "gpu/command_buffer/service/gles2_cmd_decoder_autogen.h"
15754 15755
15755 } // namespace gles2 15756 } // namespace gles2
15756 } // namespace gpu 15757 } // namespace gpu
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698