chrome/browser/resources/settings/on_startup_page/startup_urls_page.html - Issue 1752633002: MD Settings: disable the On Startup "OK" button with no site content

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

Issue 1752633002: MD Settings: disable the On Startup "OK" button with no site content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: disabled Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/on_startup_page/startup_urls_page.js » ('j') | chrome/browser/resources/settings/on_startup_page/startup_urls_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

index 85ab07f76a4697268f7cb427ac07c6e220443dff..6ba1e63707741f269ec30d885af0c26818dcc4f5 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html

@@ -39,17 +39,16 @@

<paper-input class="flex" always-float-label

- i18n-values="label:onStartupSiteUrl" value="{{newUrl}}">

+ i18n-values="label:onStartupSiteUrl" value="{{newUrl_}}">

</paper-input>

</div>

<paper-button class="cancel-button" on-tap="onCancelTap_"

id="cancel" i18n-content="cancel"></paper-button>

- <!-- TODO(dbeam): this button should be [disabled] when |newUrl|

- is empty. -->

<paper-button class="call-to-action" on-tap="onOkTap_"

- id="addUrlButton" i18n-content="add"></paper-button>

+ id="addUrlButton" i18n-content="add"

+ disabled="[[!isOkAllowed_(newUrl_)]]"></paper-button>

</div>