MD Settings: disable the On Startup "OK" button with no site content

MD Settings: disable the On Startup "OK" button with no site content

We should not be asking the user to tap a "DO THIS!" button when it
would have no effect.  Instead, mark the button [disabled] (and style it
so that it's clear tapping it has no effect) until there's content in
URL input to add an On Startup page.

R=dschuyler@chromium.org
BUG=531750
Committed: https://crrev.com/c6bc4b5f4c626290eb3a0a884bbb0ccdcd407d88
Cr-Commit-Position: refs/heads/master@{#379066}

[Dan Beam, 2016-03-01 02:03:03]

Patchset #1 (id:1) has been deleted

[dschuyler, 2016-03-01 03:15:53]

https://codereview.chromium.org/1752633002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
(right):

https://codereview.chromium.org/1752633002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:92:
return this.newUrl_.length > 0;
Can we re-add the trim() to avoid urls like ' ' and '   http://example.com'

[Dan Beam, 2016-03-02 19:54:21]

Patchset #1 (id:20001) has been deleted

[Dan Beam, 2016-03-02 19:56:20]

Patchset #2 (id:60001) has been deleted

[Dan Beam, 2016-03-02 19:56:42]

https://codereview.chromium.org/1752633002/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/on_startup_page/startup_urls_page.js
(right):

https://codereview.chromium.org/1752633002/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/on_startup_page/startup_urls_page.js:92:
return this.newUrl_.length > 0;
On 2016/03/01 03:15:52, dschuyler wrote:
> Can we re-add the trim() to avoid urls like ' ' and '   http://example.com

Done.

[dschuyler, 2016-03-02 20:05:03]

lgtm

[Dan Beam, 2016-03-03 19:15:38]

i will add tests soon or when we add real validation

[Dan Beam, 2016-03-03 19:15:42]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2016-03-03 19:16:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752633002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752633002/80001

[commit-bot: I haz the power, 2016-03-03 20:05:57]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-03-03 20:07:44]

Description was changed from

==========
MD Settings: disable the On Startup "OK" button with no site content

We should not be asking the user to tap a "DO THIS!" button when it
would have no effect.  Instead, mark the button [disabled] (and style it
so that it's clear tapping it has no effect) until there's content in
URL input to add an On Startup page.

R=dschuyler@chromium.org
BUG=531750
==========

to

==========
MD Settings: disable the On Startup "OK" button with no site content

We should not be asking the user to tap a "DO THIS!" button when it
would have no effect.  Instead, mark the button [disabled] (and style it
so that it's clear tapping it has no effect) until there's content in
URL input to add an On Startup page.

R=dschuyler@chromium.org
BUG=531750

Committed: https://crrev.com/c6bc4b5f4c626290eb3a0a884bbb0ccdcd407d88
Cr-Commit-Position: refs/heads/master@{#379066}
==========

[commit-bot: I haz the power, 2016-03-03 20:07:46]

Patchset 2 (id:??) landed as
https://crrev.com/c6bc4b5f4c626290eb3a0a884bbb0ccdcd407d88
Cr-Commit-Position: refs/heads/master@{#379066}