chrome/common/chrome_switches.cc - Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/chrome_switches.cc

Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use Event structure Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/webstore_installer.cc ('K') | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/api/webstore.json » ('j') | chrome/common/extensions/api/webstore.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/chrome_switches.cc

diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc

index 415d583fe87efd9d406bc123f11b691210012658..be2ff0b1da0bd4f4f43fbc4b3f21538c45c81113 100644

--- a/chrome/common/chrome_switches.cc

+++ b/chrome/common/chrome_switches.cc

@@ -87,6 +87,12 @@ const char kAppsGalleryDownloadURL[] = "apps-gallery-download-url";

// confirmation dialog. A value of 'accept' means to always act as if the dialog

// was accepted, and 'cancel' means to always act as if the dialog was

// cancelled.

+//

+// TODO (rdevlin.cronin): Remove this.

+// This is not a good use of a command-line flag, as it would be equally

+// effective as a global boolean. Additionally, this opens up a dangerous way

+// for attackers to append a commandline flag and circumvent all user action for

+// installing an extension.

const char kAppsGalleryInstallAutoConfirmForTests[] =

"apps-gallery-install-auto-confirm-for-tests";