chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html - Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html

Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: separate pure-virtual change Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/webstore_custom_bindings.js ('K') | « chrome/test/data/extensions/api_test/webstore_inline_install/install_stage_listener.html ('k') | chrome/test/data/extensions/api_test/webstore_inline_install/set_null_listener.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html

diff --git a/chrome/test/data/extensions/api_test/webstore_inline_install/install.html b/chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html

similarity index 61%

copy from chrome/test/data/extensions/api_test/webstore_inline_install/install.html

copy to chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html

index 6cf0f673749d7fd7afbddf9852bacfba61350fcc..d566e947c288ebd5af2d26f80b2d5b713db5382d 100644

--- a/chrome/test/data/extensions/api_test/webstore_inline_install/install.html

+++ b/chrome/test/data/extensions/api_test/webstore_inline_install/set_invalid_listener.html

@@ -5,10 +5,10 @@

</head>

<body>

- console.log('Page loaded');

function runTest(galleryUrl) {

- console.log('In runTest');

+ var caughtError = false;

+ var kExpectedErrorMessage =

+ 'The listener callback for install stage change must be a function.';

// Link URL has to be generated dynamically in order to include the right

// port number. The ID corresponds to the data in the "extension" directory.

@@ -16,12 +16,23 @@

galleryUrl + '/detail/ecglahbcnmdpdciemllbhojghbkagdje';

try {

+ try {

+ chrome.webstore.setInstallStageListener("not a function");

+ } catch (e) {

+ if (e != kExpectedErrorMessage) {

+ console.log('Unexpected error: ' + e);

+ window.domAutomationController.send(false);

+ }

+ caughtError = true;

+ }

chrome.webstore.install(

undefined,

function() {

- console.log('Ran test, sending response');

+ if (!caughtError) {

+ console.log('Test failed: Did not catch error for invalid arg.');

+ window.domAutomationController.send(false);

+ }

window.domAutomationController.send(true);

- console.log('Test complete');

function(error) {

console.log('Unexpected error: ' + error);

@@ -32,6 +43,7 @@

window.gc();

} catch (e) {

console.log('Unexpected exception: ' + e);

+ console.log(e.stack);

window.domAutomationController.send(false);

throw e;

}