Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8338)

Unified Diff: chrome/renderer/extensions/webstore_bindings.h

Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: separate pure-virtual change Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/webstore_bindings.h
diff --git a/chrome/renderer/extensions/webstore_bindings.h b/chrome/renderer/extensions/webstore_bindings.h
index b729150a9855753754dfb6c0c20657292c2e48de..ebcf0baafa61e3cb2eaa5b5b3ed05a64186195a0 100644
--- a/chrome/renderer/extensions/webstore_bindings.h
+++ b/chrome/renderer/extensions/webstore_bindings.h
@@ -9,6 +9,10 @@
#include "chrome/renderer/extensions/chrome_v8_extension.h"
#include "third_party/WebKit/public/web/WebFrame.h"
+namespace content {
+class RenderView;
+}
+
namespace extensions {
class ChromeV8Context;
@@ -25,11 +29,24 @@ class WebstoreBindings : public ChromeV8Extension,
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
private:
+ // Returns the RenderView from the WebFrame, or NULL on failure.
+ content::RenderView* GetRenderView();
not at google - send to devlin 2014/02/27 21:49:56 this method already exists on ChromeV8Extension
Devlin 2014/02/28 18:04:51 Oh. Whoops. Done.
+
void Install(const v8::FunctionCallbackInfo<v8::Value>& args);
void OnInlineWebstoreInstallResponse(
int install_id, bool success, const std::string& error);
+ void OnInlineInstallStageChanged(const std::string& stage);
+
+ void OnInlineInstallDownloadProgress(int percent_downloaded);
+
+ void ValidateInstallStageListener(
+ const v8::FunctionCallbackInfo<v8::Value>& args);
+
+ void ValidateDownloadProgressListener(
+ const v8::FunctionCallbackInfo<v8::Value>& args);
+
// Extracts a Web Store item ID from a <link rel="chrome-webstore-item"
// href="https://chrome.google.com/webstore/detail/id"> node found in the
// frame. On success, true will be returned and the |webstore_item_id|

Powered by Google App Engine
This is Rietveld 408576698