Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3628)

Unified Diff: chrome/browser/extensions/activity_log/activity_log.h

Issue 175263003: Add chrome.webstore API methods to allow sites to see progress of installation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore/webstore_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/activity_log/activity_log.h
diff --git a/chrome/browser/extensions/activity_log/activity_log.h b/chrome/browser/extensions/activity_log/activity_log.h
index 84ffd397f6cf95a39659e5a262e7176a0f5189d1..b0087b259541313a6e6955fb32cab0fd4d5f61f2 100644
--- a/chrome/browser/extensions/activity_log/activity_log.h
+++ b/chrome/browser/extensions/activity_log/activity_log.h
@@ -82,20 +82,9 @@ class ActivityLog : public BrowserContextKeyedService,
// Extension::InstallObserver
// We keep track of whether the whitelisted extension is installed; if it is,
// we want to recompute whether to have logging enabled.
- virtual void OnExtensionInstalled(const Extension* extension) OVERRIDE {}
felt 2014/02/25 23:30:40 Why is this disappearing with no replacement? Will
Devlin 2014/02/25 23:40:46 Shouldn't break it, I hope :) Just removed the pu
felt 2014/02/25 23:43:41 Ah, I see. Also, it looks like someone has made p
virtual void OnExtensionLoaded(const Extension* extension) OVERRIDE;
virtual void OnExtensionUnloaded(const Extension* extension) OVERRIDE;
virtual void OnExtensionUninstalled(const Extension* extension) OVERRIDE;
- // We also have to list the following from InstallObserver.
- virtual void OnBeginExtensionInstall(
- const ExtensionInstallParams& params) OVERRIDE {}
- virtual void OnDownloadProgress(const std::string& extension_id,
- int percent_downloaded) OVERRIDE {}
- virtual void OnInstallFailure(const std::string& extension_id) OVERRIDE {}
- virtual void OnAppsReordered() OVERRIDE {}
- virtual void OnAppInstalledToAppList(
- const std::string& extension_id) OVERRIDE {}
- virtual void OnShutdown() OVERRIDE {}
// ApiActivityMonitor
virtual void OnApiEventDispatched(
« no previous file with comments | « no previous file | chrome/browser/extensions/api/webstore/webstore_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698