Add chrome.webstore API methods to allow sites to see progress of installation

chrome/browser/extensions/install_observer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_INSTALL_OBSERVER_H_
 #define CHROME_BROWSER_EXTENSIONS_INSTALL_OBSERVER_H_
 
 #include <string>
 
 #include "ui/gfx/image/image_skia.h"
@@ skipping 17 matching lines @@
     gfx::ImageSkia installing_icon;
     bool is_app;
     bool is_platform_app;
     bool is_ephemeral;
   };
 
   // Called at the beginning of the complete installation process, i.e., this
   // is called before the extension download begins.
   virtual void OnBeginExtensionInstall(const ExtensionInstallParams& params);
 
+  // Called when the Extension begins the download process.
+  // This is typically, but not always, almost immediately after
+  // OnBeginExtensionInstall(). In some cases, though, the extension may already
+  // be downloaded, so we don't want to group the two together incorrectly.

[not at google - send to devlin, 2014/02/27 21:49:56]

nit: this comment has too many commas in it.

[Devlin, 2014/02/28 18:04:51]

Haha fair enough, I suppose, though, really, there could have been, maybe, a few
more?

+  virtual void OnBeginExtensionDownload(const std::string& extension_id);
+
   // Called whenever the extension download is updated.
   // Note: Some extensions have multiple modules, so the percent included here
   // is a simple calculation of:
   // (finished_files * 100 + current_file_progress) / (total files * 100).
   virtual void OnDownloadProgress(const std::string& extension_id,
                                   int percent_downloaded);
 
+  // Called when the necessary downloads have completed, and the crx

[not at google - send to devlin, 2014/02/27 21:49:56]

nit: unnecessary comma

[Devlin, 2014/02/28 18:04:51]

I'm defending this one! :P
http://www.hamilton.edu/writing/seven-sins-of-writing/the-second-deadly-sin-i...
Rule (a).

+  // installation is due to start.
+  virtual void OnBeginCrxInstall(const std::string& extension_id);
+
   // Called if the extension fails to install.
   virtual void OnInstallFailure(const std::string& extension_id);
 
   // Called if the installation succeeds.
   virtual void OnExtensionInstalled(const Extension* extension);
 
   // Called when an extension is [Loaded, Unloaded, Uninstalled] or an app is
   // installed to the app list. These are simply forwarded from the
   // chrome::NOTIFICATIONs.
   virtual void OnExtensionLoaded(const Extension* extension);
   virtual void OnExtensionUnloaded(const Extension* extension);
   virtual void OnExtensionUninstalled(const Extension* extension);
   virtual void OnAppInstalledToAppList(const std::string& extension_id);
 
   // Called when the app list is reordered.
   virtual void OnAppsReordered();
 
   // Notifies observers that the observed object is going away.
   virtual void OnShutdown();
 
  protected:
   virtual ~InstallObserver() {}
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_INSTALL_OBSERVER_H_