Chromium Code Reviews
DescriptionRemove DialogDelegate::Accept() variant
The one and only place it was used (HungRendererDialogView) was unnecessary. Overriding Close() to no-op would accomplish the same behavior. However I also discovered a bug (linked below) which I fixed. So this patch creates a behavioral change: pressing escape or otherwise closing the window does the same thing as pressing "Wait", which I believe is desirable.
BUG=591186, 585312
Committed: https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4
Cr-Commit-Position: refs/heads/master@{#378659}
Patch Set 1 #Patch Set 2 : . #
Messages
Total messages: 13 (7 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||