Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 1752623004: Remove DialogDelegate::Accept() variant (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove DialogDelegate::Accept() variant The one and only place it was used (HungRendererDialogView) was unnecessary. Overriding Close() to no-op would accomplish the same behavior. However I also discovered a bug (linked below) which I fixed. So this patch creates a behavioral change: pressing escape or otherwise closing the window does the same thing as pressing "Wait", which I believe is desirable. BUG=591186, 585312 Committed: https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4 Cr-Commit-Position: refs/heads/master@{#378659}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -50 lines) Patch
M chrome/browser/ui/views/hung_renderer_view.h View 1 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 5 chunks +20 lines, -35 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/window/dialog_delegate.cc View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Evan Stade
4 years, 9 months ago (2016-03-01 22:23:43 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752623004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752623004/1
4 years, 9 months ago (2016-03-01 22:24:50 UTC) #6
sky
LGTM
4 years, 9 months ago (2016-03-02 00:25:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752623004/20001
4 years, 9 months ago (2016-03-02 01:02:08 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 02:21:26 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 02:22:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1203e605ab26d27ee100afaec794d3c77beaa2a4
Cr-Commit-Position: refs/heads/master@{#378659}

Powered by Google App Engine
This is Rietveld 408576698