Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Unified Diff: chrome/browser/ui/search/instant_page.cc

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Edited histogram summary Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_page.cc
diff --git a/chrome/browser/ui/search/instant_page.cc b/chrome/browser/ui/search/instant_page.cc
index a35d44fabfd12e9b26798bf12c2d683cb35f2479..4f42d763f6426d292a64a6991ae66e861b736b4f 100644
--- a/chrome/browser/ui/search/instant_page.cc
+++ b/chrome/browser/ui/search/instant_page.cc
@@ -143,6 +143,7 @@ bool InstantPage::OnMessageReceived(const IPC::Message& message) {
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_FocusOmnibox, OnFocusOmnibox)
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxNavigate,
OnSearchBoxNavigate);
+ IPC_MESSAGE_HANDLER(ChromeViewHostMsg_LogIframeHover, OnLogIframeHover);
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxDeleteMostVisitedItem,
OnDeleteMostVisitedItem);
IPC_MESSAGE_HANDLER(ChromeViewHostMsg_SearchBoxUndoMostVisitedDeletion,
@@ -258,6 +259,13 @@ void InstantPage::OnSearchBoxNavigate(int page_id,
contents(), url, transition, disposition, is_search_type);
}
+void InstantPage::OnLogIframeHover(int page_id) {
+ if (!contents()->IsActiveEntry(page_id))
+ return;
+
+ delegate_->LogIframeHover();
Jered 2013/06/28 16:24:17 Here, call InstantNTP::LogIframeHover(contents()).
annark1 2013/06/28 18:38:22 Done.
+}
+
void InstantPage::OnDeleteMostVisitedItem(int page_id, const GURL& url) {
if (!contents()->IsActiveEntry(page_id))
return;

Powered by Google App Engine
This is Rietveld 408576698