Log NTP hovers in 1993 clients

chrome/browser/ui/search/instant_controller.cc

Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index e58b0e7c79e70299242fe9a1c761c3232de586a0..de198e22c6dfbf0a9806b9cce90ea0299ea9bea9 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -1039,6 +1039,15 @@ void InstantController::TabDeactivated(content::WebContents* contents) {
 
   if (GetOverlayContents())
     HideOverlay();
+
+  // If user is deactivating an NTP tab, log the number of mouseovers for this
+  // NTP session.
+  if (ntp_ && (chrome::MatchesOriginAndPath(

[Jered, 2013/06/28 16:24:17]

Instead, say
if (chrome::IsInstantNTP(contents))

[annark1, 2013/06/28 18:38:22]

Done.

+                   GURL(GetInstantURL()), contents->GetURL()) ||
+               chrome::MatchesOriginAndPath(
+                   GURL(GetLocalInstantURL()), contents->GetURL()))) {
+    ntp_->LogTotalMouseovers(contents);

[Jered, 2013/06/28 16:24:17]

ntp_ is a preloaded new tab page, not the one that has just been deactivated.
This method should be static, so this call would just be
InstantNTP::LogTotalMouseovers(contents);

[annark1, 2013/06/28 18:38:22]

Done.

+  }
 }
 
 void InstantController::SetInstantEnabled(bool instant_enabled,
@@ -1879,6 +1888,13 @@ void InstantController::PopulateInstantAutocompleteResultFromMatch(
       << result->transition <<  " " << result->autocomplete_match_index;
 }
 
+void InstantController::LogIframeHover() {

[Jered, 2013/06/28 16:24:17]

Omit this method on InstantController. Handle this entirely from InstantPage.

[annark1, 2013/06/28 18:38:22]

Done.

+  if (!browser_ || !browser_->GetActiveWebContents() || !ntp_)
+    return;
+
+  ntp_->LogIframeHover(browser_->GetActiveWebContents());
+}
+
 bool InstantController::IsJavascriptEnabled() const {
   GURL instant_url(GetInstantURL());
   GURL origin(instant_url.GetOrigin());