Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2119)

Unified Diff: chrome/browser/resources/local_ntp/most_visited_title.js

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Spacing fixes Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/local_ntp/most_visited_title.js
diff --git a/chrome/browser/resources/local_ntp/most_visited_title.js b/chrome/browser/resources/local_ntp/most_visited_title.js
index 703219c161c706805ebb3295cd3f49e7ffb6302b..702096a00984e17002666c1487447c5e03f40e54 100644
--- a/chrome/browser/resources/local_ntp/most_visited_title.js
+++ b/chrome/browser/resources/local_ntp/most_visited_title.js
@@ -11,7 +11,16 @@ window.addEventListener('DOMContentLoaded', function() {
'use strict';
fillMostVisited(window.location, function(params, data) {
- document.body.appendChild(
- createMostVisitedLink(params, data.url, data.title, data.title));
+ function handleMouseOver() {
+ var params = parseQueryParams(document.location);
+ if ('pos' in params && isFinite(params.pos)) {
+ var pos = parseInt(params.pos, 10);
+ var ntpApiHandle = chrome.embeddedSearch.newTabPage;
+ ntpApiHandle.logEvent('NewTabPage.NumberOfMouseOvers', 1, null, pos);
+ }
+ };
beaudoin 2013/06/22 01:14:53 Seems to be duplicated code, one more reason to ad
annark1 2013/06/25 16:01:38 Done.
+ var link = createMostVisitedLink(params, data.url, data.title, data.title);
+ link.addEventListener('mouseover', handleMouseOver);
+ document.body.appendChild(link);
});
});

Powered by Google App Engine
This is Rietveld 408576698