Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chrome/renderer/resources/extensions/searchbox_api.js

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed OVERRIDE error Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/searchbox_api.js
diff --git a/chrome/renderer/resources/extensions/searchbox_api.js b/chrome/renderer/resources/extensions/searchbox_api.js
index 7d2daa5668768f6e4961d43f43dee3bd12b72720..ec21ac10cc88dfb6ff12efc558fd5a4a251a573c 100644
--- a/chrome/renderer/resources/extensions/searchbox_api.js
+++ b/chrome/renderer/resources/extensions/searchbox_api.js
@@ -259,6 +259,7 @@ if (!chrome.embeddedSearch) {
native function NavigateNewTabPage();
native function IsInputInProgress();
native function GetAppLauncherEnabled();
+ native function LogEvent();
function GetMostVisitedItemsWrapper() {
var mostVisitedItems = GetMostVisitedItems();
@@ -292,7 +293,12 @@ if (!chrome.embeddedSearch) {
};
this.navigateContentWindow = function(destination, disposition) {
NavigateNewTabPage(destination, disposition);
- }
+ };
+ // This method is restricted to chrome-search://most-visited pages by
+ // checking the invoking context's origin in searchbox_extension.cc.
+ this.logEvent = function(histogram_name) {
+ LogEvent(histogram_name);
+ };
this.onmostvisitedchange = null;
this.onthemechange = null;

Powered by Google App Engine
This is Rietveld 408576698