Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Side by Side Diff: chrome/browser/ui/search/instant_page.h

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Edited histogram summary Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_
6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_ 6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 // Called when the page wants to navigate to |url|. Usually used by the 85 // Called when the page wants to navigate to |url|. Usually used by the
86 // page to navigate to privileged destinations (e.g. chrome:// URLs) or to 86 // page to navigate to privileged destinations (e.g. chrome:// URLs) or to
87 // navigate to URLs that are hidden from the page using Restricted IDs (rid 87 // navigate to URLs that are hidden from the page using Restricted IDs (rid
88 // in the API). 88 // in the API).
89 virtual void NavigateToURL(const content::WebContents* contents, 89 virtual void NavigateToURL(const content::WebContents* contents,
90 const GURL& url, 90 const GURL& url,
91 content::PageTransition transition, 91 content::PageTransition transition,
92 WindowOpenDisposition disposition, 92 WindowOpenDisposition disposition,
93 bool is_search_type) = 0; 93 bool is_search_type) = 0;
94 94
95 // Used to log in UMA the total number of mouseovers over NTP tiles/titles.
Jered 2013/06/28 16:24:17 Remove this.
annark1 2013/06/28 18:38:22 Done.
96 virtual void LogIframeHover() = 0;
97
95 // Called when the SearchBox wants to delete a Most Visited item. 98 // Called when the SearchBox wants to delete a Most Visited item.
96 virtual void DeleteMostVisitedItem(const GURL& url) = 0; 99 virtual void DeleteMostVisitedItem(const GURL& url) = 0;
97 100
98 // Called when the SearchBox wants to undo a Most Visited deletion. 101 // Called when the SearchBox wants to undo a Most Visited deletion.
99 virtual void UndoMostVisitedDeletion(const GURL& url) = 0; 102 virtual void UndoMostVisitedDeletion(const GURL& url) = 0;
100 103
101 // Called when the SearchBox wants to undo all Most Visited deletions. 104 // Called when the SearchBox wants to undo all Most Visited deletions.
102 virtual void UndoAllMostVisitedDeletions() = 0; 105 virtual void UndoAllMostVisitedDeletions() = 0;
103 106
104 // Called when the page fails to load for whatever reason. 107 // Called when the page fails to load for whatever reason.
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 const std::vector<InstantSuggestion>& suggestions); 209 const std::vector<InstantSuggestion>& suggestions);
207 void OnShowInstantOverlay(int page_id, 210 void OnShowInstantOverlay(int page_id,
208 int height, 211 int height,
209 InstantSizeUnits units); 212 InstantSizeUnits units);
210 void OnFocusOmnibox(int page_id, OmniboxFocusState state); 213 void OnFocusOmnibox(int page_id, OmniboxFocusState state);
211 void OnSearchBoxNavigate(int page_id, 214 void OnSearchBoxNavigate(int page_id,
212 const GURL& url, 215 const GURL& url,
213 content::PageTransition transition, 216 content::PageTransition transition,
214 WindowOpenDisposition disposition, 217 WindowOpenDisposition disposition,
215 bool is_search_type); 218 bool is_search_type);
219 void OnLogIframeHover(int page_id);
216 void OnDeleteMostVisitedItem(int page_id, const GURL& url); 220 void OnDeleteMostVisitedItem(int page_id, const GURL& url);
217 void OnUndoMostVisitedDeletion(int page_id, const GURL& url); 221 void OnUndoMostVisitedDeletion(int page_id, const GURL& url);
218 void OnUndoAllMostVisitedDeletions(int page_id); 222 void OnUndoAllMostVisitedDeletions(int page_id);
219 223
220 void ClearContents(); 224 void ClearContents();
221 225
222 Delegate* const delegate_; 226 Delegate* const delegate_;
223 scoped_ptr<InstantIPCSender> ipc_sender_; 227 scoped_ptr<InstantIPCSender> ipc_sender_;
224 const std::string instant_url_; 228 const std::string instant_url_;
225 const bool is_incognito_; 229 const bool is_incognito_;
226 230
227 DISALLOW_COPY_AND_ASSIGN(InstantPage); 231 DISALLOW_COPY_AND_ASSIGN(InstantPage);
228 }; 232 };
229 233
230 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_ 234 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_PAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698