Log NTP hovers in 1993 clients

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/i18n/rtl.h"
+#include "base/metrics/histogram.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/common/autocomplete_match_type.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/instant_types.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/searchbox/searchbox.h"
 #include "content/public/renderer/render_view.h"
@@ skipping 26 matching lines @@
 const char kCSSBackgroundRepeatX[] = "repeat-x";
 const char kCSSBackgroundRepeatY[] = "repeat-y";
 const char kCSSBackgroundRepeat[] = "repeat";
 
 const char kThemeAttributionFormat[] =
     "chrome-search://theme/IDR_THEME_NTP_ATTRIBUTION?%s";
 
 const char kLTRHtmlTextDirection[] = "ltr";
 const char kRTLHtmlTextDirection[] = "rtl";
 
+const int kDefaultUmaMin = 1;
+const int kDefaultUmaMax = 1000000;
+const int kDefaultUmaBucketCount = 50;
+
 // Converts a V8 value to a string16.
 string16 V8ValueToUTF16(v8::Handle<v8::Value> v) {
   v8::String::Value s(v);
   return string16(reinterpret_cast<const char16*>(*s), s.length());
 }
 
 // Converts string16 to V8 String.
 v8::Handle<v8::String> UTF16ToV8String(const string16& s) {
   return v8::String::New(reinterpret_cast<const uint16_t*>(s.data()), s.size());
 }
@@ skipping 576 matching lines @@
   // chrome-search://suggestion can call this function.
   static void GetSuggestionData(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Gets the raw data for a most visited item including its raw URL.
   // GetRenderViewWithCheckedOrigin() enforces that only code in the origin
   // chrome-search://most-visited can call this function.
   static void GetMostVisitedItemData(
     const v8::FunctionCallbackInfo<v8::Value>& args);
 
+  // Logs information from the iframes on the NTP.
+  static void LogEvent(const v8::FunctionCallbackInfo<v8::Value>& args);
+
   // Gets whether the omnibox has focus or not.
   static void IsFocused(const v8::FunctionCallbackInfo<v8::Value>& args);
 
   // Gets whether user input is in progress.
   static void IsInputInProgress(
       const v8::FunctionCallbackInfo<v8::Value>& args);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(SearchBoxExtensionWrapper);
 };
@@ skipping 72 matching lines @@
   if (name->Equals(v8::String::New("UndoMostVisitedDeletion")))
     return v8::FunctionTemplate::New(UndoMostVisitedDeletion);
   if (name->Equals(v8::String::New("ShowBars")))
     return v8::FunctionTemplate::New(ShowBars);
   if (name->Equals(v8::String::New("HideBars")))
     return v8::FunctionTemplate::New(HideBars);
   if (name->Equals(v8::String::New("GetSuggestionData")))
     return v8::FunctionTemplate::New(GetSuggestionData);
   if (name->Equals(v8::String::New("GetMostVisitedItemData")))
     return v8::FunctionTemplate::New(GetMostVisitedItemData);
+  if (name->Equals(v8::String::New("LogEvent")))
+    return v8::FunctionTemplate::New(LogEvent);
   if (name->Equals(v8::String::New("IsFocused")))
     return v8::FunctionTemplate::New(IsFocused);
   if (name->Equals(v8::String::New("IsInputInProgress")))
     return v8::FunctionTemplate::New(IsInputInProgress);
   return v8::Handle<v8::FunctionTemplate>();
 }
 
 // static
 content::RenderView* SearchBoxExtensionWrapper::GetRenderView() {
   WebKit::WebFrame* webframe = WebKit::WebFrame::frameForCurrentContext();
@@ skipping 699 matching lines @@
   if (!SearchBox::Get(render_view)->GetMostVisitedItemWithID(
           restricted_id, &mv_item)) {
     return;
   }
   args.GetReturnValue().Set(
       GenerateMostVisitedItem(render_view->GetRoutingID(), restricted_id,
                               mv_item));
 }
 
 // static
+void SearchBoxExtensionWrapper::LogEvent(
+    const v8::FunctionCallbackInfo<v8::Value>& args) {
+  content::RenderView* render_view = GetRenderViewWithCheckedOrigin(
+      GURL(chrome::kChromeSearchMostVisitedUrl));
+  if (!render_view) return;
+
+  if (args.Length() < 2 || !args[0]->IsString() || !args[1]->IsNumber())
+    return;
+
+  DVLOG(1) << render_view << " LogEvent";
+
+  std::string histogram_name = *v8::String::Utf8Value(args[0]->ToString());
+  int value = args[1]->IntegerValue();
+
+  if (histogram_name == "NewTabPage.NumberOfMouseOvers") {
+    SearchBox::Get(render_view)->LogIframeHover();
+    return;
+  }
+
+  if (!args[2]->IsNull() && args[2]->IsNumber()) {

[Jered, 2013/06/26 16:37:57]

What is up with this code? I don't see where it's invoked, so I'm not sure what
it is supposed to be doing.

[annark1, 2013/06/28 15:30:49]

This was intended to make the LogEvent function more general, but as there are
no other features/logging events using it at this time, I've removed it.
On 2013/06/26 16:37:57, Jered wrote:

+    int boundary = args[2]->IntegerValue();
+    int bucket_count = boundary;
+    while (bucket_count >= 100) {
+      bucket_count /= 10;
+    }
+    // As |histogram_name| may change between calls, the
+    // UMA_HISTOGRAM_ENUMERATION macro cannot be used here.
+    base::HistogramBase* counter =
+        base::LinearHistogram::FactoryGet(
+            histogram_name, 1, boundary, bucket_count + 1,
+            base::HistogramBase::kUmaTargetedHistogramFlag);
+    counter->Add(value);
+  } else {
+    // See above comment regarding UMA macros.
+    base::HistogramBase* counter =
+        base::Histogram::FactoryGet(
+            histogram_name,
+            kDefaultUmaMin,
+            kDefaultUmaMax,
+            kDefaultUmaBucketCount,
+            base::HistogramBase::kUmaTargetedHistogramFlag);
+    counter->Add(value);
+  }
+}
+
+// static
 void SearchBoxExtensionWrapper::IsFocused(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view) return;
 
   bool is_focused = SearchBox::Get(render_view)->is_focused();
   DVLOG(1) << render_view << " IsFocused: " << is_focused;
   args.GetReturnValue().Set(is_focused);
 }
 
@@ skipping 89 matching lines @@
   Dispatch(frame, kDispatchInputCancelScript);
 }
 
 // static
 void SearchBoxExtension::DispatchToggleVoiceSearch(
     WebKit::WebFrame* frame) {
   Dispatch(frame, kDispatchToggleVoiceSearchScript);
 }
 
 }  // namespace extensions_v8