Log NTP hovers in 1993 clients

chrome/renderer/resources/extensions/searchbox_api.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chrome;
 if (!chrome)
   chrome = {};
 
 if (!chrome.embeddedSearch) {
   chrome.embeddedSearch = new function() {
@@ skipping 240 matching lines @@
       // =======================================================================
       //                            Private functions
       // =======================================================================
       native function GetMostVisitedItems();
       native function GetThemeBackgroundInfo();
       native function DeleteMostVisitedItem();
       native function UndoAllMostVisitedDeletions();
       native function UndoMostVisitedDeletion();
       native function NavigateNewTabPage();
       native function IsInputInProgress();
+      native function LogEvent();
+

[beaudoin, 2013/06/22 01:14:53]

Remove blank line.

[annark1, 2013/06/25 16:01:38]

Done.

 
       function GetMostVisitedItemsWrapper() {
         var mostVisitedItems = GetMostVisitedItems();
         for (var i = 0, item; item = mostVisitedItems[i]; ++i) {
           // These properties are private data and should not be returned to
           // the page. They are only accessible via getMostVisitedItemData().
           item.url = null;
           item.title = null;
           item.domain = null;
           item.direction = null;
@@ skipping 12 matching lines @@
         DeleteMostVisitedItem(restrictedId);
       };
       this.undoAllMostVisitedDeletions = function() {
         UndoAllMostVisitedDeletions();
       };
       this.undoMostVisitedDeletion = function(restrictedId) {
         UndoMostVisitedDeletion(restrictedId);
       };
       this.navigateContentWindow = function(destination, disposition) {
         NavigateNewTabPage(destination, disposition);
-      }
+      };
+      // This method is restricted to chrome-search://most-visited pages by
+      // checking the invoking context's origin in searchbox_extension.cc.
+      this.logEvent = function(name, value, opt_boundary, opt_pos) {
+        LogEvent(name, value, opt_boundary, opt_pos);
+      };

[beaudoin, 2013/06/22 01:14:53]

Please run this by Jered since you're changing the searchbox API.

 
       this.onmostvisitedchange = null;
       this.onthemechange = null;
       this.oninputstart = null;
       this.oninputcancel = null;
     };
 
     // Export legacy searchbox API.
     // TODO: Remove this when Instant Extended is fully launched.
     chrome.searchBox = this.searchBox;
   };
 }