Log NTP hovers in 1993 clients

chrome/browser/resources/local_ntp/most_visited_thumbnail.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 /**
  * @fileoverview Rendering for iframed most visited thumbnails.
  */
 
 window.addEventListener('DOMContentLoaded', function() {
   'use strict';
 
   fillMostVisited(document.location, function(params, data) {
     function showDomainElement() {
       var link = createMostVisitedLink(params, data.url, data.title);
       var domain = document.createElement('div');
       domain.textContent = data.domain;
       link.appendChild(domain);
+      link.addEventListener('mouseover', handleMouseOver);
+      link.addEventListener('click', handleClick);

[beaudoin, 2013/06/22 01:14:53]

I don't see handleClick defined anywhere. Also, whi do you put it only on
DomainElements?

[annark1, 2013/06/25 16:01:38]

Should not have been there. Sorry, I didn't catch it from an early iteration.
On 2013/06/22 01:14:53, beaudoin wrote:

       document.body.appendChild(link);
     };
+
+    function handleMouseOver() {
+      var params = parseQueryParams(document.location);
+      if ('pos' in params && isFinite(params.pos)) {
+        var pos = parseInt(params.pos, 10);
+        var ntpApiHandle = chrome.embeddedSearch.newTabPage;
+        ntpApiHandle.logEvent('NewTabPage.NumberOfMouseOvers', 1, null, pos);
+      }
+    };

[beaudoin, 2013/06/22 01:14:53]

Would it make sense to move this to createMostVisitedLink and add the event
listeners in there? You seem to need them both for DomainElement and regular
thumbnails.

[annark1, 2013/06/25 16:01:38]

Done.

+
     if (data.thumbnailUrl) {
       var image = new Image();
       image.onload = function() {
         var shadow = document.createElement('span');
         shadow.classList.add('shadow');
         var link = createMostVisitedLink(params, data.url, data.title);
         link.appendChild(shadow);
         link.appendChild(image);
+        link.addEventListener('mouseover', handleMouseOver);
         document.body.appendChild(link);
       };
 
       image.onerror = showDomainElement;
       image.src = data.thumbnailUrl;
     } else {
       showDomainElement();
     }
   });
 });