Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: chrome/browser/ui/search/instant_ntp.h

Issue 17526008: Log NTP hovers in 1993 clients (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed OVERRIDE error Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/search/instant_controller.cc ('k') | chrome/browser/ui/search/instant_ntp.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_ 5 #ifndef CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_
6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_ 6 #define CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 24 matching lines...) Expand all
35 // |on_stale_callback| will be called when |loader_| determines the page to 35 // |on_stale_callback| will be called when |loader_| determines the page to
36 // be stale. 36 // be stale.
37 void InitContents(Profile* profile, 37 void InitContents(Profile* profile,
38 const content::WebContents* active_tab, 38 const content::WebContents* active_tab,
39 const base::Closure& on_stale_callback); 39 const base::Closure& on_stale_callback);
40 40
41 // Releases the WebContents for the Instant page. This should be called when 41 // Releases the WebContents for the Instant page. This should be called when
42 // the page is about to be committed. 42 // the page is about to be committed.
43 scoped_ptr<content::WebContents> ReleaseContents(); 43 scoped_ptr<content::WebContents> ReleaseContents();
44 44
45 // Used to log each time the user mouses over NTP tiles or titles.
samarth 2013/07/11 18:29:47 Sorry for the extremely late comments but please m
46 static void CountMouseover(content::WebContents* contents);
47
48 // Used to log in UMA the total number of mouseovers over NTP tiles/titles.
49 static void EmitMouseoverCount(content::WebContents* contents);
50
45 private: 51 private:
46 // Overridden from content::WebContentsObserver: 52 // Overridden from content::WebContentsObserver:
47 virtual void RenderViewCreated( 53 virtual void RenderViewCreated(
48 content::RenderViewHost* render_view_host) OVERRIDE; 54 content::RenderViewHost* render_view_host) OVERRIDE;
49 virtual void RenderViewGone( 55 virtual void RenderViewGone(
50 base::TerminationStatus status) OVERRIDE; 56 base::TerminationStatus status) OVERRIDE;
51 57
52 // Overriden from InstantLoader::Delegate: 58 // Overriden from InstantLoader::Delegate:
53 virtual void OnSwappedContents() OVERRIDE; 59 virtual void OnSwappedContents() OVERRIDE;
54 virtual void OnFocus() OVERRIDE; 60 virtual void OnFocus() OVERRIDE;
55 virtual void OnMouseDown() OVERRIDE; 61 virtual void OnMouseDown() OVERRIDE;
56 virtual void OnMouseUp() OVERRIDE; 62 virtual void OnMouseUp() OVERRIDE;
57 virtual content::WebContents* OpenURLFromTab( 63 virtual content::WebContents* OpenURLFromTab(
58 content::WebContents* source, 64 content::WebContents* source,
59 const content::OpenURLParams& params) OVERRIDE; 65 const content::OpenURLParams& params) OVERRIDE;
60 virtual void LoadCompletedMainFrame() OVERRIDE; 66 virtual void LoadCompletedMainFrame() OVERRIDE;
61 67
62 InstantLoader loader_; 68 InstantLoader loader_;
63 69
64 DISALLOW_COPY_AND_ASSIGN(InstantNTP); 70 DISALLOW_COPY_AND_ASSIGN(InstantNTP);
65 }; 71 };
66 72
67 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_ 73 #endif // CHROME_BROWSER_UI_SEARCH_INSTANT_NTP_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/search/instant_controller.cc ('k') | chrome/browser/ui/search/instant_ntp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698