Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 17526006: Disable browser restart just after login (Closed)

Created:
7 years, 6 months ago by Dmitry Polukhin
Modified:
7 years, 6 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, pastarmovj
Visibility:
Public.

Description

Disable browser restart just after login This change effectively revert essential part of https://chromiumcodereview.appspot.com/16770002 It is at least second regression introduced by this changes. BUG=252442, 251261 TEST=manual R=nkostylev@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207797

Patch Set 1 #

Total comments: 2

Patch Set 2 : added #if 0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Polukhin
7 years, 6 months ago (2013-06-21 09:43:13 UTC) #1
Nikita (slow)
https://codereview.chromium.org/17526006/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (left): https://codereview.chromium.org/17526006/diff/1/chrome/browser/chromeos/login/login_utils.cc#oldcode254 chrome/browser/chromeos/login/login_utils.cc:254: CommandLine user_flags(CommandLine::NO_PROGRAM); Let's leave this code and put it ...
7 years, 6 months ago (2013-06-21 10:49:24 UTC) #2
Nikita (slow)
lgtm
7 years, 6 months ago (2013-06-21 10:55:44 UTC) #3
Dmitry Polukhin
https://codereview.chromium.org/17526006/diff/1/chrome/browser/chromeos/login/login_utils.cc File chrome/browser/chromeos/login/login_utils.cc (left): https://codereview.chromium.org/17526006/diff/1/chrome/browser/chromeos/login/login_utils.cc#oldcode254 chrome/browser/chromeos/login/login_utils.cc:254: CommandLine user_flags(CommandLine::NO_PROGRAM); On 2013/06/21 10:49:24, Nikita Kostylev wrote: > ...
7 years, 6 months ago (2013-06-21 10:59:31 UTC) #4
Dmitry Polukhin
7 years, 6 months ago (2013-06-21 11:14:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r207797 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698