Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 1752553002: [MD] Fix some ink drop colors (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 9 months ago
Reviewers:
varkha, sky, bruthig
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Fix some ink drop colors BUG=590843 Committed: https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca Cr-Commit-Position: refs/heads/master@{#378397}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -40 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 2 chunks +5 lines, -1 line 1 comment Download
M chrome/browser/ui/views/toolbar/app_menu_button.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/app_menu_button.cc View 1 chunk +0 lines, -11 lines 1 comment Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 1 chunk +5 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Evan Stade
https://codereview.chromium.org/1752553002/diff/20001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc File chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc (right): https://codereview.chromium.org/1752553002/diff/20001/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc#newcode230 chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc:230: SkColor GetInkDropBaseColor() const override { Moving this here makes ...
4 years, 9 months ago (2016-03-01 00:23:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752553002/20001
4 years, 9 months ago (2016-03-01 00:24:12 UTC) #4
bruthig
lgtm
4 years, 9 months ago (2016-03-01 01:24:52 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 01:28:41 UTC) #7
Evan Stade
+sky for OWNERS
4 years, 9 months ago (2016-03-01 01:50:27 UTC) #9
varkha
lgtm
4 years, 9 months ago (2016-03-01 03:04:22 UTC) #10
sky
LGTM
4 years, 9 months ago (2016-03-01 04:00:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752553002/20001
4 years, 9 months ago (2016-03-01 04:51:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-01 04:57:24 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 04:58:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/84e53c857ee87964ca99b52cc892a407b56e2dca
Cr-Commit-Position: refs/heads/master@{#378397}

Powered by Google App Engine
This is Rietveld 408576698