Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1752543002: Add CFX_FloatRect::ToFxRect(). (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M core/include/fxcrt/fx_coordinates.h View 3 chunks +12 lines, -7 lines 0 comments Download
M core/src/fxcrt/fx_basic_coords.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_pageobjs.cpp View 3 chunks +3 lines, -9 lines 0 comments Download
M fpdfsdk/src/pdfwindow/PWL_Utils.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Dan, for review.
4 years, 9 months ago (2016-02-29 23:47:03 UTC) #2
dsinclair
lgtm
4 years, 9 months ago (2016-03-01 01:06:49 UTC) #4
Tom Sepez
4 years, 9 months ago (2016-03-01 01:27:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
020fd8a9f715b7a0e9f9d9689245ebee1e2e7e18 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698