Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2835)

Unified Diff: Source/platform/fonts/FontPlatformData.cpp

Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fighting trunk TestExpectation changes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/FontPlatformData.h ('k') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/FontPlatformData.cpp
diff --git a/Source/platform/fonts/FontPlatformData.cpp b/Source/platform/fonts/FontPlatformData.cpp
index 42a9928cdacfbe324a9be375a8da54d44a49e91b..c96b9c4879e55425915ba16d8794bbb10bdf2412 100644
--- a/Source/platform/fonts/FontPlatformData.cpp
+++ b/Source/platform/fonts/FontPlatformData.cpp
@@ -153,6 +153,38 @@ FontPlatformData::FontPlatformData(const FontPlatformData& source)
#endif
}
+FontPlatformData::FontPlatformData(const FontPlatformData& src, float textSize)
+ : m_typeface(src.m_typeface)
+#if !OS(WIN)
+ , m_family(src.m_family)
+#endif
+ , m_textSize(textSize)
+ , m_syntheticBold(src.m_syntheticBold)
+ , m_syntheticItalic(src.m_syntheticItalic)
+ , m_orientation(src.m_orientation)
+#if OS(MACOSX)
+ , m_isColorBitmapFont(src.m_isColorBitmapFont)
+ , m_isCompositeFontReference(src.m_isCompositeFontReference)
+#endif
+ , m_widthVariant(RegularWidth)
+#if !OS(MACOSX)
+ , m_style(src.m_style)
+#endif
+ , m_harfBuzzFace(nullptr)
+ , m_isHashTableDeletedValue(false)
+#if OS(WIN)
+ , m_paintTextFlags(src.m_paintTextFlags)
+ , m_useSubpixelPositioning(src.m_useSubpixelPositioning)
+ , m_minSizeForAntiAlias(src.m_minSizeForAntiAlias)
+ , m_minSizeForSubpixel(src.m_minSizeForSubpixel)
+#endif
+{
+#if OS(MACOSX)
+ platformDataInit(src);
+#else
+ querySystemForRenderStyle(FontDescription::subpixelPositioning());
+#endif
+}
#if OS(MACOSX)
FontPlatformData::FontPlatformData(CGFontRef cgFont, float size, bool syntheticBold, bool syntheticItalic, FontOrientation orientation, FontWidthVariant widthVariant)
@@ -194,28 +226,6 @@ FontPlatformData::FontPlatformData(PassRefPtr<SkTypeface> tf, const char* family
querySystemForRenderStyle(subpixelTextPosition);
}
-
-FontPlatformData::FontPlatformData(const FontPlatformData& src, float textSize)
- : m_typeface(src.m_typeface)
-#if !OS(WIN)
- , m_family(src.m_family)
-#endif
- , m_textSize(textSize)
- , m_syntheticBold(src.m_syntheticBold)
- , m_syntheticItalic(src.m_syntheticItalic)
- , m_orientation(src.m_orientation)
- , m_widthVariant(RegularWidth)
- , m_harfBuzzFace(nullptr)
- , m_isHashTableDeletedValue(false)
-#if OS(WIN)
- , m_paintTextFlags(src.m_paintTextFlags)
- , m_useSubpixelPositioning(src.m_useSubpixelPositioning)
- , m_minSizeForAntiAlias(src.m_minSizeForAntiAlias)
- , m_minSizeForSubpixel(src.m_minSizeForSubpixel)
-#endif
-{
- querySystemForRenderStyle(FontDescription::subpixelPositioning());
-}
#endif
FontPlatformData::~FontPlatformData()
@@ -329,13 +339,6 @@ SkTypeface* FontPlatformData::typeface() const
HarfBuzzFace* FontPlatformData::harfBuzzFace() const
{
-#if OS(MACOSX)
- CTFontRef font = ctFont();
- // Keeping the decision not to pass AAT font to HarfBuzz for now,
- // until we switch to HarfBuzz as a shaper for all cases.
- if (isAATFont(font))
- return 0;
-#endif
if (!m_harfBuzzFace)
m_harfBuzzFace = HarfBuzzFace::create(const_cast<FontPlatformData*>(this), uniqueID());
« no previous file with comments | « Source/platform/fonts/FontPlatformData.h ('k') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698