Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp - Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Marking word-spacing-characters-complex-text.html as Skip, adding canvas-normalize-string.html reba… Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.mm ('K') | « Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.mm ('k') | Source/platform/fonts/mac/ComplexTextController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

index f4dc954eabb6d2246fcbc8a0e0a3dc01c8f096be..1f2f3bcc25689338033e30ab05f5298385227372 100644

--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp

@@ -899,7 +899,6 @@ void HarfBuzzShaper::setGlyphPositionsForHarfBuzzRun(HarfBuzzRun* currentRun, hb

if (!currentRun->hasGlyphToCharacterIndexes()) {

// FIXME: https://crbug.com/337886

- ASSERT_NOT_REACHED();

return;

}