Source/web/tests/PinchViewportTest.cpp - Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/PinchViewportTest.cpp

Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased on master, TestExpectations tuned, ready to land? Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/fonts/harfbuzz/HarfBuzzFaceCoreText.mm ('K') | « Source/platform/fonts/skia/SimpleFontDataSkia.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/web/tests/PinchViewportTest.cpp

diff --git a/Source/web/tests/PinchViewportTest.cpp b/Source/web/tests/PinchViewportTest.cpp

index c18b7d663f019321b7feec51400980d66d65f83b..22c556a3084dc71487f3e0fc427223235e1fad4e 100644

--- a/Source/web/tests/PinchViewportTest.cpp

+++ b/Source/web/tests/PinchViewportTest.cpp

@@ -718,7 +718,7 @@ TEST_F(PinchViewportTest, TestRestoredFromLegacyHistoryItem)

// Test that the coordinates sent into moveRangeSelection are offset by the

// pinch viewport's location.

-TEST_F(PinchViewportTest, TestWebFrameRangeAccountsForPinchViewportScroll)

+TEST_F(PinchViewportTest, DISABLED_TestWebFrameRangeAccountsForPinchViewportScroll)

{

initializeWithDesktopSettings();

webViewImpl()->settings()->setDefaultFontSize(12);