Source/platform/fonts/Font.h - Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.h

Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased on master, TestExpectations tuned, ready to land? Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/FontPlatformData.h » ('j') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/Font.h

diff --git a/Source/platform/fonts/Font.h b/Source/platform/fonts/Font.h

index fa832473797a6c5d15fe5a014e779ad662e5ee91..db341a2cb46b6075012042a6576067dc0b61e19a 100644

--- a/Source/platform/fonts/Font.h

+++ b/Source/platform/fonts/Font.h

@@ -127,9 +127,7 @@ public:

{

return glyphDataAndPageForCharacter(c, mirror, spaceNormalize, variant).first;

}

-#if OS(MACOSX)

- const SimpleFontData* fontDataForCombiningCharacterSequence(const UChar*, size_t length, FontDataVariant) const;

-#endif

std::pair<GlyphData, GlyphPage*> glyphDataAndPageForCharacter(UChar32&, bool mirror, bool normalizeSpace = false, FontDataVariant = AutoVariant) const;

bool primaryFontHasGlyphForCharacter(UChar32) const;

« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/fonts/FontPlatformData.h » ('j') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('J')