Source/platform/BUILD.gn - Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/BUILD.gn

Issue 175253002: Switch to HarfBuzz on Mac and remove CoreText shaper (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased on master, TestExpectations tuned, ready to land? Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/BUILD.gn

diff --git a/Source/platform/BUILD.gn b/Source/platform/BUILD.gn

index 54ae27437530ca22db1eb8d54897e4420a2a04f3..40c3f5bdcc807bcd0aab786c74d666539fdf7ad0 100644

--- a/Source/platform/BUILD.gn

+++ b/Source/platform/BUILD.gn

@@ -213,15 +213,12 @@ component("platform") {

if (is_mac) {

sources -= [

- "fonts/harfbuzz/FontHarfBuzz.cpp",

- "fonts/harfbuzz/HarfBuzzFaceSkia.cpp",

"fonts/opentype/OpenTypeTypes.h",

"fonts/opentype/OpenTypeVerticalData.cpp",

"fonts/opentype/OpenTypeVerticalData.h",

# The Mac currently uses FontCustomPlatformDataMac.cpp instead.

"fonts/skia/FontCustomPlatformDataSkia.cpp",

"fonts/skia/FontCacheSkia.cpp",

- "fonts/skia/SimpleFontDataSkia.cpp",

# Uses LocaleMac instead.

"text/LocaleICU.cpp",

"text/LocaleICU.h",

@@ -250,7 +247,7 @@ component("platform") {

]

} else {

sources -= [

- "fonts/harfbuzz/HarfBuzzFaceCoreText.cpp",

+ "fonts/harfbuzz/HarfBuzzFaceCoreText.mm",

"geometry/cg/FloatPointCG.cpp",

"geometry/cg/FloatRectCG.cpp",

"geometry/cg/FloatSizeCG.cpp",

« no previous file with comments | « Source/build/features.gypi ('k') | Source/platform/blink_platform.gyp » ('j') | Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm » ('J')