Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1752523002: Support for running service tests against sky_shell (Closed)

Created:
4 years, 9 months ago by Cutch
Modified:
4 years, 9 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Support for running service tests against sky_shell BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/59873fa42a3b18b549c447627eb8544130ee12bc

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -8 lines) Patch
M runtime/observatory/tests/service/test_helper.dart View 1 5 chunks +85 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 9 months ago (2016-02-29 22:57:33 UTC) #3
turnidge
lgtm
4 years, 9 months ago (2016-03-02 17:36:16 UTC) #4
Cutch
4 years, 9 months ago (2016-03-02 18:15:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
59873fa42a3b18b549c447627eb8544130ee12bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698