SampleApp now displays gamma-correct content in "S32" and "F16" modes. The default framebuffer is a…

SampleApp now displays gamma-correct content in "S32" and "F16" modes. The default framebuffer is always (?) sRGB, but querying it to determine that is difficult or impossible. In addition, when running in "L32" mode, we stil want to exhibit the old behavior, where we pretended that it was not sRGB. Thus, set the pixel config of the render target based on the window's color and profile types. That triggers our code to turn on linear->sRGB conversion-on-write in flushRenderTarget.

NOte: Angle does not display correctly, due to limitations in the set of ES2 extensions it exposes. However, it can still be used to generate gamma-correct images (via DM, etc...).

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752473002

Committed: https://skia.googlesource.com/skia/+/856cc17db434be717a29e1fa893a2108d1f9db36

[Brian Osman, 2016-02-29 21:37:50]

Description was changed from

==========
SampleApp now displays gamma-correct content in "S32" and "F16" modes. The
default framebuffer is always (?) sRGB, but querying it to determine that is
difficult or impossible. In addition, when running in "L32" mode, we stil want
to exhibit the old behavior, where we pretended that it was not sRGB. Thus, set
the pixel config of the render target based on the window's color and profile
types. That triggers our code to turn on linear->sRGB conversion-on-write in
flushRenderTarget.

NOte: Angle does not display correctly, due to limitations in the set of ES2
extensions it exposes. However, it can still be used to generate gamma-correct
images (via DM, etc...).

BUG=skia:
==========

to

==========
SampleApp now displays gamma-correct content in "S32" and "F16" modes. The
default framebuffer is always (?) sRGB, but querying it to determine that is
difficult or impossible. In addition, when running in "L32" mode, we stil want
to exhibit the old behavior, where we pretended that it was not sRGB. Thus, set
the pixel config of the render target based on the window's color and profile
types. That triggers our code to turn on linear->sRGB conversion-on-write in
flushRenderTarget.

NOte: Angle does not display correctly, due to limitations in the set of ES2
extensions it exposes. However, it can still be used to generate gamma-correct
images (via DM, etc...).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-02-29 21:39:41]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, reed@google.com

[reed1, 2016-02-29 22:03:55]

very excited, but defers to brian

[bsalomon, 2016-03-01 14:10:42]

On 2016/02/29 22:03:55, reed1 wrote:
> very excited, but defers to brian

lgtm, (I suppose kSkia8888 and/or kSRGBA may be the wrong byte order)

[Brian Osman, 2016-03-01 15:04:58]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-03-01 15:05:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752473002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752473002/1

[commit-bot: I haz the power, 2016-03-01 15:19:13]

Description was changed from

==========
SampleApp now displays gamma-correct content in "S32" and "F16" modes. The
default framebuffer is always (?) sRGB, but querying it to determine that is
difficult or impossible. In addition, when running in "L32" mode, we stil want
to exhibit the old behavior, where we pretended that it was not sRGB. Thus, set
the pixel config of the render target based on the window's color and profile
types. That triggers our code to turn on linear->sRGB conversion-on-write in
flushRenderTarget.

NOte: Angle does not display correctly, due to limitations in the set of ES2
extensions it exposes. However, it can still be used to generate gamma-correct
images (via DM, etc...).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
SampleApp now displays gamma-correct content in "S32" and "F16" modes. The
default framebuffer is always (?) sRGB, but querying it to determine that is
difficult or impossible. In addition, when running in "L32" mode, we stil want
to exhibit the old behavior, where we pretended that it was not sRGB. Thus, set
the pixel config of the render target based on the window's color and profile
types. That triggers our code to turn on linear->sRGB conversion-on-write in
flushRenderTarget.

NOte: Angle does not display correctly, due to limitations in the set of ES2
extensions it exposes. However, it can still be used to generate gamma-correct
images (via DM, etc...).

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/856cc17db434be717a29e1fa893a2108d1f9db36
==========

[commit-bot: I haz the power, 2016-03-01 15:19:14]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/856cc17db434be717a29e1fa893a2108d1f9db36