Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/renderer/origin_trials/trial_token_validator_unittest.cc

Issue 1752463002: Cleanup TrialToken in preparation of moving it to content/common. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/origin_trials/trial_token_validator_unittest.cc
diff --git a/content/renderer/origin_trials/trial_token_validator_unittest.cc b/content/renderer/origin_trials/trial_token_validator_unittest.cc
index 2bdb88836eebd36f3018be63fb67536b06c6a737..858aa6f1566917a20b2fedf6dfc865ce67e7427b 100644
--- a/content/renderer/origin_trials/trial_token_validator_unittest.cc
+++ b/content/renderer/origin_trials/trial_token_validator_unittest.cc
@@ -11,6 +11,7 @@
#include "base/time/time.h"
#include "content/public/renderer/content_renderer_client.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
namespace content {
@@ -84,7 +85,10 @@ class TestContentRendererClient : public content::ContentRendererClient {
class TrialTokenValidatorTest : public testing::Test {
public:
- TrialTokenValidatorTest() {
+ TrialTokenValidatorTest()
+ : appropriate_origin_(GURL(kAppropriateOrigin)),
+ inappropriate_origin_(GURL(kInappropriateOrigin)),
+ insecure_origin_(GURL(kInsecureOrigin)) {
SetPublicKey(kTestPublicKey);
SetRendererClientForTesting(&test_content_renderer_client_);
}
@@ -94,6 +98,9 @@ class TrialTokenValidatorTest : public testing::Test {
}
TrialTokenValidator trial_token_validator_;
+ const url::Origin appropriate_origin_;
+ const url::Origin inappropriate_origin_;
+ const url::Origin insecure_origin_;
private:
TestContentRendererClient test_content_renderer_client_;
@@ -101,40 +108,40 @@ class TrialTokenValidatorTest : public testing::Test {
TEST_F(TrialTokenValidatorTest, ValidateValidToken) {
EXPECT_TRUE(trial_token_validator_.validateToken(
- kSampleToken, kAppropriateOrigin, kAppropriateFeatureName));
+ kSampleToken, appropriate_origin_, kAppropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateInappropriateOrigin) {
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kSampleToken, kInappropriateOrigin, kAppropriateFeatureName));
+ kSampleToken, inappropriate_origin_, kAppropriateFeatureName));
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kSampleToken, kInsecureOrigin, kAppropriateFeatureName));
+ kSampleToken, insecure_origin_, kAppropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateInappropriateFeature) {
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kSampleToken, kAppropriateOrigin, kInappropriateFeatureName));
+ kSampleToken, appropriate_origin_, kInappropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateInvalidSignature) {
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kInvalidSignatureToken, kAppropriateOrigin, kAppropriateFeatureName));
+ kInvalidSignatureToken, appropriate_origin_, kAppropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateUnparsableToken) {
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kUnparsableToken, kAppropriateOrigin, kAppropriateFeatureName));
+ kUnparsableToken, appropriate_origin_, kAppropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateExpiredToken) {
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kExpiredToken, kAppropriateOrigin, kAppropriateFeatureName));
+ kExpiredToken, appropriate_origin_, kAppropriateFeatureName));
}
TEST_F(TrialTokenValidatorTest, ValidateValidTokenWithIncorrectKey) {
SetPublicKey(kTestPublicKey2);
EXPECT_FALSE(TrialTokenValidator().validateToken(
- kSampleToken, kAppropriateOrigin, kAppropriateFeatureName));
+ kSampleToken, appropriate_origin_, kAppropriateFeatureName));
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698