Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1752433002:
Simplify the poly union. (Closed)
DescriptionSimplify the poly union.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1752433002
Committed: https://skia.googlesource.com/skia/+/683ea9a08d43cc3a3a5ca7f1bc3452823a881f82
Patch Set 1 #Patch Set 2 : work around clang compiler. #
Messages
Total messages: 24 (13 generated)
Description was changed from ========== Simplify the poly union. BUG=skia: ========== to ========== Simplify the poly union. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752433002/1
Description was changed from ========== Simplify the poly union. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify the poly union. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
herb@google.com changed reviewers: + mtklein@google.com, reed@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
mtklein@chromium.org changed reviewers: + mtklein@chromium.org
lgtm
The CQ bit was checked by herb@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752433002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
work around clang compiler.
The CQ bit was checked by herb@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752433002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by herb@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org Link to the patchset: https://codereview.chromium.org/1752433002/#ps20001 (title: "work around clang compiler.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752433002/20001
Message was sent while issue was closed.
Description was changed from ========== Simplify the poly union. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Simplify the poly union. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/683ea9a08d43cc3a3a5ca7f1bc3452823a881f82 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/683ea9a08d43cc3a3a5ca7f1bc3452823a881f82 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
