Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chromeos/dbus/shill_manager_client.h

Issue 175243004: Chrome OS: Use Manager.DefaultService for Default Network (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/network/network_state_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_manager_client.h
diff --git a/chromeos/dbus/shill_manager_client.h b/chromeos/dbus/shill_manager_client.h
index a128b469748609dbad202f10859575f18ec431e3..90373bac4f2decc0edb817dfa1a26f1f16c715c9 100644
--- a/chromeos/dbus/shill_manager_client.h
+++ b/chromeos/dbus/shill_manager_client.h
@@ -57,6 +57,10 @@ class CHROMEOS_EXPORT ShillManagerClient : public DBusClient {
// Used to reset all properties; does not notify observers.
virtual void ClearProperties() = 0;
+ // Set manager property.
+ virtual void SetManagerProperty(const std::string& key,
+ const base::Value& value) = 0;
+
// Add/Remove/ClearService should only be called from ShillServiceClient.
virtual void AddManagerService(const std::string& service_path,
bool add_to_visible_list,
@@ -64,8 +68,15 @@ class CHROMEOS_EXPORT ShillManagerClient : public DBusClient {
virtual void RemoveManagerService(const std::string& service_path) = 0;
virtual void ClearManagerServices() = 0;
- // Called by ShillServiceClient when a service's State property changes.
- // Services are sorted first by Active vs. Inactive State, then by Type.
+ // Called by ShillServiceClient when a service's State property changes,
+ // before notifying observers. Sets the DefaultService property to empty
+ // if the state changes to a non-connected state.
+ virtual void ServiceStateChanged(const std::string& service_path,
+ const std::string& state) = 0;
+
+ // Called by ShillServiceClient when a service's State property changes,
+ // after notifying observers. Services are sorted first by Active or
+ // Inactive State, then by Type.
virtual void SortManagerServices() = 0;
protected:
« no previous file with comments | « chromeos/dbus/fake_shill_service_client.cc ('k') | chromeos/network/network_state_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698