Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chromeos/network/network_state_handler.h

Issue 175243004: Chrome OS: Use Manager.DefaultService for Default Network (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler.h
diff --git a/chromeos/network/network_state_handler.h b/chromeos/network/network_state_handler.h
index 6f6d978e7310ca22a1b98667dcb39df0f826426a..99d2a314bf25a78fa1e96a928ce73f5dec41ca30 100644
--- a/chromeos/network/network_state_handler.h
+++ b/chromeos/network/network_state_handler.h
@@ -281,6 +281,11 @@ class CHROMEOS_EXPORT NetworkStateHandler
virtual void ManagedStateListChanged(
ManagedState::ManagedType type) OVERRIDE;
+ // Called when the default network service changes. Sets default_network_path_
+ // and notifies listeners.
+ virtual void DefaultNetworkServiceChanged(
+ const std::string& service_path) OVERRIDE;
+
// Called after construction. Called explicitly by tests after adding
// test observers.
void InitShillPropertyHandler();
@@ -314,15 +319,11 @@ class CHROMEOS_EXPORT NetworkStateHandler
// Helper function to notify observers. Calls CheckDefaultNetworkChanged().
void OnNetworkConnectionStateChanged(NetworkState* network);
- // If the default network changed returns true and sets
- // |default_network_path_|.
- bool CheckDefaultNetworkChanged();
-
- // Logs an event and notifies observers.
- void OnDefaultNetworkChanged();
+ // Notifies observers when the default network or its properties change.
+ void NotifyDefaultNetworkChanged(const NetworkState* default_network);
// Notifies observers about changes to |network|.
- void NetworkPropertiesUpdated(const NetworkState* network);
+ void NotifyNetworkPropertiesUpdated(const NetworkState* network);
// Called whenever Device.Scanning state transitions to false.
void ScanCompleted(const std::string& type);

Powered by Google App Engine
This is Rietveld 408576698