Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 17524007: Delete deprecated methods from v8-profiler.h (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne, loislo
CC:
v8-dev, alph
Visibility:
Public.

Description

Delete deprecated methods from v8-profiler.h All these methods were already marked as V8_DEPRECATED in V8 Version 3.18.0 (see https://code.google.com/p/v8/source/browse/trunk/include/v8-profiler.h?r=14304) so it is time to delete them. BUG=None R=loislo@chromium.org, svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15260

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -234 lines) Patch
M include/v8-profiler.h View 13 chunks +1 line, -62 lines 0 comments Download
M src/api.cc View 8 chunks +0 lines, -162 lines 0 comments Download
M src/global-handles.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 5 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yurys
7 years, 6 months ago (2013-06-21 07:32:02 UTC) #1
loislo
lgtm
7 years, 6 months ago (2013-06-21 07:34:30 UTC) #2
Sven Panne
lgtm
7 years, 6 months ago (2013-06-21 07:48:11 UTC) #3
yurys
7 years, 6 months ago (2013-06-21 07:56:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r15260 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698