Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1752383002: Get rid of silly "done" flag in SetPropertyIternal now that we can just return (Closed)

Created:
4 years, 9 months ago by Toon Verwaest
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Get rid of silly "done" flag in SetPropertyIternal now that we can just return BUG= Committed: https://crrev.com/b7a43514043c179ed4aca1724e8c70eabb596845 Cr-Commit-Position: refs/heads/master@{#34436}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -19 lines) Patch
M src/lookup.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.cc View 1 6 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
4 years, 9 months ago (2016-03-02 14:38:14 UTC) #2
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-02 14:54:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752383002/20001
4 years, 9 months ago (2016-03-02 15:22:13 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 15:43:47 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 15:44:16 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b7a43514043c179ed4aca1724e8c70eabb596845
Cr-Commit-Position: refs/heads/master@{#34436}

Powered by Google App Engine
This is Rietveld 408576698