Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: src/gpu/effects/GrRRectEffect.h

Issue 175233002: Hide GrRRectEffect class from header (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: improve comment Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/effects/GrRRectEffect.cpp » ('j') | src/gpu/effects/GrRRectEffect.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/effects/GrRRectEffect.h
diff --git a/src/gpu/effects/GrRRectEffect.h b/src/gpu/effects/GrRRectEffect.h
index 3d899e2a09b5bde52f5048cca05e169b4b547f9c..b73d1e6939abe32f959ed29d2e8cab587d618d81 100644
--- a/src/gpu/effects/GrRRectEffect.h
+++ b/src/gpu/effects/GrRRectEffect.h
@@ -8,42 +8,17 @@
#ifndef GrRRectEffect_DEFINED
#define GrRRectEffect_DEFINED
-#include "GrEffect.h"
+#include "GrTypes.h"
-#include "SkRRect.h"
+class GrEffectRef;
+class SkRRect;
-class GrGLRRectEffect;
-
-/**
- * An effect that performs anti-aliasing for an SkRRect. It doesn't support all varieties of SkRRect
- * so the caller must check for a NULL return from the Create() method.
- */
-class GrRRectEffect : public GrEffect {
-public:
- static GrEffectRef* Create(const SkRRect&);
-
- virtual ~GrRRectEffect();
- static const char* Name() { return "RRect"; }
-
- const SkRRect& getRRect() const { return fRRect; }
-
- typedef GrGLRRectEffect GLEffect;
-
- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;
-
- virtual const GrBackendEffectFactory& getFactory() const SK_OVERRIDE;
-
-private:
- GrRRectEffect(const SkRRect&);
-
- virtual bool onIsEqual(const GrEffect& other) const SK_OVERRIDE;
-
- SkRRect fRRect;
-
- GR_DECLARE_EFFECT_TEST;
-
- typedef GrEffect INHERITED;
+namespace GrRRectEffect {
+ /**
robertphillips 2014/02/21 14:39:58 An -> an?
bsalomon 2014/02/21 15:36:21 Done.
+ * Creates An effect that performs anti-aliased clipping against an SkRRect. It doesn't support
+ * all varieties of SkRRect so the caller must check for a NULL return.
+ */
+ GrEffectRef* Create(const SkRRect&);
};
-
#endif
« no previous file with comments | « no previous file | src/gpu/effects/GrRRectEffect.cpp » ('j') | src/gpu/effects/GrRRectEffect.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698