Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2686)

Unified Diff: chrome/installer/test/alternate_version_generator.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/test/alternate_version_generator.cc
diff --git a/chrome/installer/test/alternate_version_generator.cc b/chrome/installer/test/alternate_version_generator.cc
index 1a367c2d7cc6c94992ec810f1f7e89d36ef09e70..b50e02603f5d68050fef771c546e0e047236e54c 100644
--- a/chrome/installer/test/alternate_version_generator.cc
+++ b/chrome/installer/test/alternate_version_generator.cc
@@ -211,7 +211,7 @@ bool MappedFile::Initialize(base::File file) {
} else {
PLOG(DFATAL) << "file.GetInfo failed";
}
- file_ = file.Pass();
+ file_ = std::move(file);
return result;
}
@@ -391,7 +391,7 @@ bool UpdateVersionIfMatch(const base::FilePath& image_file,
if (file.IsValid()) {
MappedFile image_mapping;
- if (image_mapping.Initialize(file.Pass())) {
+ if (image_mapping.Initialize(std::move(file))) {
base::win::PEImageAsData image(
reinterpret_cast<HMODULE>(image_mapping.data()));
// PEImage class does not support other-architecture images.
« no previous file with comments | « chrome/chrome_watcher/chrome_watcher_main.cc ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698