chrome/browser/ui/pdf/pdf_unsupported_feature.cc - Issue 1752233002: Convert Pass()→std::move() on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/pdf/pdf_unsupported_feature.cc

diff --git a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

index 796a51f273c97d7091a17b1fd659414000c4fb5f..092b7a8dc3eaa5eff71c30539a423e6d6d066e8b 100644

--- a/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

+++ b/chrome/browser/ui/pdf/pdf_unsupported_feature.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/ui/pdf/pdf_unsupported_feature.h"

+#include <utility>

#include "base/bind.h"

#include "base/macros.h"

#include "base/memory/scoped_ptr.h"

@@ -327,7 +329,7 @@ void MaybeShowOpenPDFInReaderPrompt(WebContents* web_contents,

new PDFUnsupportedFeaturePromptClient(web_contents, reader_info));

pdf::PDFWebContentsHelper* pdf_tab_helper =

pdf::PDFWebContentsHelper::FromWebContents(web_contents);

- pdf_tab_helper->ShowOpenInReaderPrompt(prompt.Pass());

+ pdf_tab_helper->ShowOpenInReaderPrompt(std::move(prompt));

}

void GotPluginsCallback(int process_id,