chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc - Issue 1752233002: Convert Pass()→std::move() on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/blacklist_load_analyzer_win.cc ('k') | chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

index d367cd80be18750f20e1841f0f1d01598ed6e60e..59aeda4649b310adc53b8d2093dc4a07392ce3d0 100644

--- a/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/platform_state_store.cc

@@ -154,9 +154,9 @@ scoped_ptr<base::DictionaryValue> Load(Profile* profile) {

UMA_HISTOGRAM_ENUMERATION(

"SBIRS.PSSLoadResult", static_cast<uint32_t>(result),

static_cast<uint32_t>(PlatformStateStoreLoadResult::NUM_RESULTS));

- return value_dict.Pass();

+ return value_dict;

#else

- return scoped_ptr<base::DictionaryValue>();

+ return nullptr;

#endif

}