chrome/browser/password_manager/password_store_factory.cc - Issue 1752233002: Convert Pass()→std::move() on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_store_factory.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/password_manager/password_store_factory.cc

diff --git a/chrome/browser/password_manager/password_store_factory.cc b/chrome/browser/password_manager/password_store_factory.cc

index 379164cb4deb25c7aeed075d728ae9415636e68d..f298ff93e19505a9e63289fb7122b2e3eb2c3f3c 100644

--- a/chrome/browser/password_manager/password_store_factory.cc

+++ b/chrome/browser/password_manager/password_store_factory.cc

@@ -162,7 +162,7 @@ PasswordStoreFactory::BuildServiceInstanceFor(

scoped_refptr<PasswordStore> ps;

#if defined(OS_WIN)

ps = new PasswordStoreWin(main_thread_runner, db_thread_runner,

- login_db.Pass(),

+ std::move(login_db),

WebDataServiceFactory::GetPasswordWebDataForProfile(

profile, ServiceAccessType::EXPLICIT_ACCESS));

#elif defined(OS_MACOSX)