chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc - Issue 1752233002: Convert Pass()→std::move() on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/component_updater/sw_reporter_installer_win.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher_win.cc » ('j') | chrome/browser/ui/views/status_icons/status_tray_state_changer_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

index 800fd74ea3b005d36423db93957260bc745a7b3b..3dd4d8a40448cd77e95e46f97cce0f9f109c1cad 100644

--- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

@@ -213,7 +213,7 @@ TEST_F(NativeMessagingTest, SingleSendMessageWrite) {

FILE_ATTRIBUTE_NORMAL | FILE_FLAG_OVERLAPPED, NULL));

ASSERT_TRUE(read_handle.IsValid());

- read_file = read_handle.Pass();

+ read_file = std::move(read_handle);

#else // defined(OS_WIN)

base::PlatformFile pipe_handles[2];

ASSERT_EQ(0, pipe(pipe_handles));