base/memory/scoped_ptr_unittest.cc - Issue 1752233002: Convert Pass()→std::move() on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/scoped_ptr_unittest.cc

Issue 1752233002: Convert Pass()→std::move() on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/memory/scoped_ptr_unittest.cc

diff --git a/base/memory/scoped_ptr_unittest.cc b/base/memory/scoped_ptr_unittest.cc

index f48657d07ef1cbe3dd90ffca8aedd7e25ade3cc8..ba977c7e9b5825852a70a40e19b2ad595826c30e 100644

--- a/base/memory/scoped_ptr_unittest.cc

+++ b/base/memory/scoped_ptr_unittest.cc

@@ -402,7 +402,8 @@ TEST(ScopedPtrTest, MoveBehavior) {

EXPECT_TRUE(scoper3.get());

}

-#if !defined(OS_ANDROID) && !defined(OS_LINUX) && !defined(OS_MACOSX)

+#if !defined(OS_ANDROID) && !defined(OS_LINUX) && !defined(OS_MACOSX) && \

+ !defined(OS_WIN)

// Test uncaught Pass() does not have side effects, because Pass()

// is implemented by std::move().

// TODO(danakj): Remove this test case when we remove Pass().