third_party/libxml/src/valid.c - Issue 1752223002: Roll libxml to 2.9.3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libxml/src/valid.c

Issue 1752223002: Roll libxml to 2.9.3 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-cherry-pick fprintf formatting fix. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libxml/src/valid.c

diff --git a/third_party/libxml/src/valid.c b/third_party/libxml/src/valid.c

index 409aa81dad69e2353ee5698799de0b62e0b4c5ca..45a3f703a24caa3458bceaad1150b25f6c27c1f7 100644

--- a/third_party/libxml/src/valid.c

+++ b/third_party/libxml/src/valid.c

@@ -2634,8 +2634,10 @@ xmlAddID(xmlValidCtxtPtr ctxt, xmlDocPtr doc, const xmlChar *value,

* The id is already defined in this DTD.

- xmlErrValidNode(ctxt, attr->parent, XML_DTD_ID_REDEFINED,

- "ID %s already defined\n", value, NULL, NULL);

+ if (ctxt != NULL) {

+ xmlErrValidNode(ctxt, attr->parent, XML_DTD_ID_REDEFINED,

+ "ID %s already defined\n", value, NULL, NULL);

+ }

#endif /* LIBXML_VALID_ENABLED */

xmlFreeID(ret);

return(NULL);