DevTools: migrate protocol dispatcher off RefPtr.

third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 103 matching lines @@
     OwnPtr<protocol::DictionaryValue> headersObject = protocol::DictionaryValue::create();
     for (const auto& header : headers)
         headersObject->setString(header.key.string(), header.value);
     protocol::ErrorSupport errors;
     return protocol::Network::Headers::parse(headersObject.get(), &errors);
 }
 
 class InspectorFileReaderLoaderClient final : public FileReaderLoaderClient {
     WTF_MAKE_NONCOPYABLE(InspectorFileReaderLoaderClient);
 public:
-    InspectorFileReaderLoaderClient(PassRefPtr<BlobDataHandle> blob, PassOwnPtr<TextResourceDecoder> decoder, PassRefPtr<GetResponseBodyCallback> callback)
+    InspectorFileReaderLoaderClient(PassRefPtr<BlobDataHandle> blob, PassOwnPtr<TextResourceDecoder> decoder, PassOwnPtr<GetResponseBodyCallback> callback)
         : m_blob(blob)
         , m_decoder(decoder)
         , m_callback(callback)
     {
         m_loader = FileReaderLoader::create(FileReaderLoader::ReadByClient, this);
     }
 
     ~InspectorFileReaderLoaderClient() override { }
 
     void start(ExecutionContext* executionContext)
@@ skipping 40 matching lines @@
 
 private:
     void dispose()
     {
         m_rawData.clear();
         delete this;
     }
 
     RefPtr<BlobDataHandle> m_blob;
     OwnPtr<TextResourceDecoder> m_decoder;
-    RefPtr<GetResponseBodyCallback> m_callback;
+    OwnPtr<GetResponseBodyCallback> m_callback;
     OwnPtr<FileReaderLoader> m_loader;
     OwnPtr<ArrayBufferBuilder> m_rawData;
 };
 
 KURL urlWithoutFragment(const KURL& url)
 {
     KURL result = url;
     result.removeFragmentIdentifier();
     return result;
 }
@@ skipping 697 matching lines @@
 void InspectorResourceAgent::setUserAgentOverride(ErrorString*, const String& userAgent)
 {
     m_state->setString(ResourceAgentState::userAgentOverride, userAgent);
 }
 
 void InspectorResourceAgent::setExtraHTTPHeaders(ErrorString*, const PassOwnPtr<protocol::Network::Headers> headers)
 {
     m_state->setObject(ResourceAgentState::extraRequestHeaders, headers->serialize());
 }
 
-bool InspectorResourceAgent::getResponseBodyBlob(const String& requestId, PassRefPtr<GetResponseBodyCallback> callback)
+bool InspectorResourceAgent::canGetResponseBodyBlob(const String& requestId)
 {
     NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);
-    if (!resourceData)
+    BlobDataHandle* blob = resourceData ? resourceData->downloadedFileBlob() : nullptr;
+    if (!blob)
         return false;
-    if (BlobDataHandle* blob = resourceData->downloadedFileBlob()) {
-        if (LocalFrame* frame = IdentifiersFactory::frameById(m_inspectedFrames, resourceData->frameId())) {
-            if (Document* document = frame->document()) {
-                InspectorFileReaderLoaderClient* client = new InspectorFileReaderLoaderClient(blob, InspectorPageAgent::createResourceTextDecoder(resourceData->mimeType(), resourceData->textEncodingName()), callback);
-                client->start(document);
-                return true;
-            }
-        }
-    }
-    return false;
+    LocalFrame* frame = IdentifiersFactory::frameById(m_inspectedFrames, resourceData->frameId());
+    return frame && frame->document();
 }
 
+void InspectorResourceAgent::getResponseBodyBlob(const String& requestId, PassOwnPtr<GetResponseBodyCallback> callback)
+{
+    NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);
+    BlobDataHandle* blob = resourceData->downloadedFileBlob();
+    LocalFrame* frame = IdentifiersFactory::frameById(m_inspectedFrames, resourceData->frameId());
+    Document* document = frame->document();
+    InspectorFileReaderLoaderClient* client = new InspectorFileReaderLoaderClient(blob, InspectorPageAgent::createResourceTextDecoder(resourceData->mimeType(), resourceData->textEncodingName()), callback);
+    client->start(document);
+}
 
-void InspectorResourceAgent::getResponseBody(ErrorString* errorString, const String& requestId, PassRefPtr<GetResponseBodyCallback> passCallback)
+void InspectorResourceAgent::getResponseBody(ErrorString* errorString, const String& requestId, PassOwnPtr<GetResponseBodyCallback> passCallback)
 {
-    RefPtr<GetResponseBodyCallback> callback = passCallback;
+    OwnPtr<GetResponseBodyCallback> callback = passCallback;
     NetworkResourcesData::ResourceData const* resourceData = m_resourcesData->data(requestId);
     if (!resourceData) {
         callback->sendFailure("No resource with given identifier found");
         return;
     }
 
     // XHR with ResponseTypeBlob should be returned as blob.
-    if (resourceData->xhrReplayData() && getResponseBodyBlob(requestId, callback))
+    if (resourceData->xhrReplayData() && canGetResponseBodyBlob(requestId)) {
+        getResponseBodyBlob(requestId, callback.release());
         return;
+    }
 
     if (resourceData->hasContent()) {
         callback->sendSuccess(resourceData->content(), resourceData->base64Encoded());
         return;
     }
 
     if (resourceData->isContentEvicted()) {
         callback->sendFailure("Request content was evicted from inspector cache");
         return;
     }
 
     if (resourceData->buffer() && !resourceData->textEncodingName().isNull()) {
         String content;
         if (InspectorPageAgent::sharedBufferContent(resourceData->buffer(), resourceData->textEncodingName(), false, &content)) {
             callback->sendSuccess(content, false);
             return;
         }
     }
 
     if (resourceData->cachedResource()) {
         String content;
         bool base64Encoded = false;
         if (InspectorPageAgent::cachedResourceContent(resourceData->cachedResource(), &content, &base64Encoded)) {
             callback->sendSuccess(content, base64Encoded);
             return;
         }
     }
 
-    if (getResponseBodyBlob(requestId, callback))
+    if (canGetResponseBodyBlob(requestId)) {
+        getResponseBodyBlob(requestId, callback.release());
         return;
+    }
 
     callback->sendFailure("No data found for resource with given identifier");
 }
 
 void InspectorResourceAgent::addBlockedURL(ErrorString*, const String& url)
 {
     protocol::DictionaryValue* blockedURLs = m_state->getObject(ResourceAgentState::blockedURLs);
     if (!blockedURLs) {
         OwnPtr<protocol::DictionaryValue> newList = protocol::DictionaryValue::create();
         blockedURLs = newList.get();
@@ skipping 129 matching lines @@
     , m_removeFinishedReplayXHRTimer(this, &InspectorResourceAgent::removeFinishedReplayXHRFired)
 {
 }
 
 bool InspectorResourceAgent::shouldForceCORSPreflight()
 {
     return m_state->booleanProperty(ResourceAgentState::cacheDisabled, false);
 }
 
 } // namespace blink