Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1752213003: DevTools: migrate protocol dispatcher off RefPtr. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, cmumford, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, jsbell+idb_chromium.org, kinuko+watch, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: migrate protocol dispatcher off RefPtr. BUG=580337 Committed: https://crrev.com/56a35fcc3bc960b6373ab1c5769901c70bc2d400 Cr-Commit-Position: refs/heads/master@{#378696}

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -185 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp View 1 4 chunks +4 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 5 chunks +24 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/WorkerInspectorController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 19 chunks +29 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 23 chunks +24 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 7 chunks +40 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 10 chunks +55 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template View 3 chunks +9 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Parser.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 9 months ago (2016-03-02 01:39:32 UTC) #2
dgozman
lgtm
4 years, 9 months ago (2016-03-02 02:02:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752213003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752213003/20001
4 years, 9 months ago (2016-03-02 02:41:52 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 05:11:32 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 05:13:01 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/56a35fcc3bc960b6373ab1c5769901c70bc2d400
Cr-Commit-Position: refs/heads/master@{#378696}

Powered by Google App Engine
This is Rietveld 408576698