Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Issue 1752203002: Fix issues in name resolution (Closed)

Created:
4 years, 9 months ago by hausner
Modified:
4 years, 9 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix issues in name resolution Looking up a name x in the library scope or in a prefix can also return the setter name x=. There were several situations that were not handled right. - a getter x and a setter x= should not result in a duplicate name error (and thus a resolution error at runtime). - when looking for an untangled name x but a setter x= is found first, keep looking for x. BUG=25625 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/5a0a097188532a7348040499aee19695173f67cf

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -10 lines) Patch
M runtime/vm/object.cc View 1 5 chunks +41 lines, -4 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +8 lines, -1 line 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
4 years, 9 months ago (2016-03-02 16:53:49 UTC) #3
regis
LGTM
4 years, 9 months ago (2016-03-02 17:53:47 UTC) #4
hausner
4 years, 9 months ago (2016-03-02 18:44:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5a0a097188532a7348040499aee19695173f67cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698