Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: lib/runtime/dart/_js_helper.js

Issue 1752193002: Add a few more known non-null cases (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart/_isolate_helper.js ('k') | lib/runtime/dart/async.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_js_helper.js
diff --git a/lib/runtime/dart/_js_helper.js b/lib/runtime/dart/_js_helper.js
index 64a1ca882bdc66c8bc837690f71318f2f9a2f2ad..b5433e79d5339ab5cc1644c228f3f35cde7148de 100644
--- a/lib/runtime/dart/_js_helper.js
+++ b/lib/runtime/dart/_js_helper.js
@@ -387,7 +387,7 @@ dart_library.library('dart/_js_helper', null, /* Imports */[
result.write(dart.dindex(receiver, i));
result.write(to);
}
- return dart.toString(result);
+ return result.toString();
}
} else {
let quoter = new RegExp(ESCAPE_REGEXP, 'g');
@@ -429,7 +429,7 @@ dart_library.library('dart/_js_helper', null, /* Imports */[
startIndex = match.end;
}
buffer.write(dart.dcall(onNonMatch, dart.dsend(receiver, 'substring', startIndex)));
- return dart.toString(buffer);
+ return buffer.toString();
}
dart.fn(stringReplaceAllFuncUnchecked);
function stringReplaceAllEmptyFuncUnchecked(receiver, onMatch, onNonMatch) {
@@ -453,7 +453,7 @@ dart_library.library('dart/_js_helper', null, /* Imports */[
}
buffer.write(dart.dcall(onMatch, new StringMatch(i, dart.as(receiver, core.String), "")));
buffer.write(dart.dcall(onNonMatch, ""));
- return dart.toString(buffer);
+ return buffer.toString();
}
dart.fn(stringReplaceAllEmptyFuncUnchecked);
function stringReplaceAllStringFuncUnchecked(receiver, pattern, onMatch, onNonMatch) {
@@ -474,7 +474,7 @@ dart_library.library('dart/_js_helper', null, /* Imports */[
startIndex = dart.notNull(position) + dart.notNull(patternLength);
}
buffer.write(dart.dcall(onNonMatch, dart.dsend(receiver, 'substring', startIndex)));
- return dart.toString(buffer);
+ return buffer.toString();
}
dart.fn(stringReplaceAllStringFuncUnchecked);
function stringReplaceFirstUnchecked(receiver, from, to, startIndex) {
« no previous file with comments | « lib/runtime/dart/_isolate_helper.js ('k') | lib/runtime/dart/async.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698