Issue 1752183003: Handle incomplete rule options gracefully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1752183003: Handle incomplete rule options gracefully. (Closed)

Created:
4 years, 9 months ago by pquitslund

Modified:
4 years, 9 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Handle incomplete rule options gracefully. Net-net: this fixes the case where we get storms of UNDEFINED_LINT_WARNINGs when parsed yaml nodes have null values. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/8cd8d219cae6c1289e92d4b563d81d1b61514e61

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	pkg/analysis_server/lib/src/services/linter/linter.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/services/linter/linter_test.dart	View		2 chunks	+12 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

4 years, 9 months ago (2016-03-03 17:58:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8cd8d219cae6c1289e92d4b563d81d1b61514e61 (presubmit successful).