Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1752183002: Pull in libFuzzer as a third party dep. (Closed)

Created:
4 years, 9 months ago by Oliver Chang
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang, Nico, aizatsky
CC:
chromium-reviews, kcc2, inferno, mmoroz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pull in libFuzzer as a third party dep. This makes it so that developers no longer have to build clang locally to get libFuzzer. R=thakis@chromium.org,aizatsky@chromium.org BUG=591248, 598448 # Previous patchset passed CQ bots, but had a trivial conflict when # trying to apply because of catapult roll. NOTRY=true Committed: https://crrev.com/cbd1cf202d289ccaf76aa67828e9425e5a061d6b Cr-Commit-Position: refs/heads/master@{#384692}

Patch Set 1 #

Patch Set 2 : DEPS #

Patch Set 3 : Update readme. #

Total comments: 3

Patch Set 4 : move negative config #

Total comments: 2

Patch Set 5 : add svn revision comment #

Patch Set 6 : checklicenses #

Patch Set 7 : rolling libfuzzer to pick up license header changes #

Patch Set 8 : rebase #

Patch Set 9 : rebase again because catapalt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -51 lines) Patch
M .gitignore View 1 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -0 lines 0 comments Download
M testing/libfuzzer/BUILD.gn View 1 2 3 1 chunk +2 lines, -17 lines 0 comments Download
A third_party/libFuzzer/BUILD.gn View 1 2 3 1 chunk +21 lines, -0 lines 0 comments Download
A + third_party/libFuzzer/LICENSE.TXT View 2 chunks +27 lines, -33 lines 0 comments Download
A + third_party/libFuzzer/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/libFuzzer/README.chromium View 1 2 3 4 5 6 1 chunk +13 lines, -0 lines 0 comments Download
M tools/checklicenses/checklicenses.py View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 54 (23 generated)
Oliver Chang
Nico, Mike, mind taking a look at this?
4 years, 9 months ago (2016-03-02 01:09:30 UTC) #1
Nico
Do we really want to just check in these files? Don't we'd rather want to ...
4 years, 9 months ago (2016-03-02 01:12:24 UTC) #2
Oliver Chang
On 2016/03/02 01:12:24, Nico wrote: > Do we really want to just check in these ...
4 years, 9 months ago (2016-03-02 01:19:13 UTC) #3
Nico
On 2016/03/02 01:19:13, Oliver Chang wrote: > On 2016/03/02 01:12:24, Nico wrote: > > Do ...
4 years, 9 months ago (2016-03-02 01:44:35 UTC) #4
Oliver Chang
On 2016/03/02 01:44:35, Nico wrote: > On 2016/03/02 01:19:13, Oliver Chang wrote: > > On ...
4 years, 9 months ago (2016-03-02 02:02:23 UTC) #5
Oliver Chang
Nico, Mike, I've updated this CL to pull in libFuzzer via DEPS. Please take a ...
4 years, 8 months ago (2016-03-31 21:58:31 UTC) #7
aizatsky
https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn File testing/libfuzzer/BUILD.gn (right): https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn#newcode15 testing/libfuzzer/BUILD.gn:15: configs -= [ "//build/config/sanitizers:default_sanitizer_coverage_flags" ] Will this negative config ...
4 years, 8 months ago (2016-03-31 22:14:44 UTC) #8
Nico
https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn File testing/libfuzzer/BUILD.gn (right): https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn#newcode15 testing/libfuzzer/BUILD.gn:15: configs -= [ "//build/config/sanitizers:default_sanitizer_coverage_flags" ] On 2016/03/31 22:14:43, aizatsky ...
4 years, 8 months ago (2016-03-31 22:24:01 UTC) #9
Oliver Chang
https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn File testing/libfuzzer/BUILD.gn (right): https://codereview.chromium.org/1752183002/diff/40001/testing/libfuzzer/BUILD.gn#newcode15 testing/libfuzzer/BUILD.gn:15: configs -= [ "//build/config/sanitizers:default_sanitizer_coverage_flags" ] On 2016/03/31 22:24:01, Nico ...
4 years, 8 months ago (2016-03-31 22:31:24 UTC) #10
Nico
lgtm! https://codereview.chromium.org/1752183002/diff/60001/DEPS File DEPS (right): https://codereview.chromium.org/1752183002/diff/60001/DEPS#newcode107 DEPS:107: 'libfuzzer_revision': '7af9c54c44b8ff3beed8456689d04628a3a8a58a', should this have a comment which ...
4 years, 8 months ago (2016-03-31 22:34:36 UTC) #11
Nico
(does this work on non-linux? if so, consider also adding a gyp file)
4 years, 8 months ago (2016-03-31 22:35:04 UTC) #12
aizatsky
On 2016/03/31 22:35:04, Nico wrote: > (does this work on non-linux? if so, consider also ...
4 years, 8 months ago (2016-03-31 22:39:57 UTC) #13
aizatsky
lgtm
4 years, 8 months ago (2016-03-31 22:40:25 UTC) #14
Nico
ok On Thu, Mar 31, 2016 at 6:39 PM, <aizatsky@chromium.org> wrote: > On 2016/03/31 22:35:04, ...
4 years, 8 months ago (2016-03-31 22:40:31 UTC) #15
Oliver Chang
thanks for reviewing! https://codereview.chromium.org/1752183002/diff/60001/DEPS File DEPS (right): https://codereview.chromium.org/1752183002/diff/60001/DEPS#newcode107 DEPS:107: 'libfuzzer_revision': '7af9c54c44b8ff3beed8456689d04628a3a8a58a', On 2016/03/31 22:34:36, Nico ...
4 years, 8 months ago (2016-03-31 22:42:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752183002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752183002/80001
4 years, 8 months ago (2016-03-31 22:47:19 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/163074)
4 years, 8 months ago (2016-03-31 22:56:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752183002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752183002/80001
4 years, 8 months ago (2016-04-01 00:36:50 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/163165)
4 years, 8 months ago (2016-04-01 00:48:23 UTC) #25
Nico
That's https://bugs.chromium.org/p/chromium/issues/detail?id=599692&q=%22file%20is%20stale%22&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified apparently On Thu, Mar 31, 2016 at 8:48 PM, commit-bot@chromium.org via codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> ...
4 years, 8 months ago (2016-04-01 01:48:26 UTC) #26
Oliver Chang
Oops, didn't notice the checklicenses failure. +Lei for checklicenses.py change for FuzzerSHA1.cpp Mike, it looks ...
4 years, 8 months ago (2016-04-01 01:55:34 UTC) #28
Lei Zhang
On 2016/04/01 01:55:34, Oliver Chang wrote: > Oops, didn't notice the checklicenses failure. +Lei for ...
4 years, 8 months ago (2016-04-01 04:28:57 UTC) #29
aizatsky
On 2016/04/01 04:28:57, Lei Zhang wrote: > On 2016/04/01 01:55:34, Oliver Chang wrote: > > ...
4 years, 8 months ago (2016-04-01 17:50:10 UTC) #30
Oliver Chang
On 2016/04/01 17:50:10, aizatsky wrote: > On 2016/04/01 04:28:57, Lei Zhang wrote: > > On ...
4 years, 8 months ago (2016-04-01 18:15:20 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752183002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752183002/120001
4 years, 8 months ago (2016-04-01 18:57:00 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/180862) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-01 18:59:25 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752183002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752183002/140001
4 years, 8 months ago (2016-04-01 19:05:19 UTC) #40
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-04-01 21:07:27 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752183002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752183002/160001
4 years, 8 months ago (2016-04-01 21:17:32 UTC) #49
commit-bot: I haz the power
Committed patchset #9 (id:160001)
4 years, 8 months ago (2016-04-01 21:37:48 UTC) #52
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 21:39:38 UTC) #54
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/cbd1cf202d289ccaf76aa67828e9425e5a061d6b
Cr-Commit-Position: refs/heads/master@{#384692}

Powered by Google App Engine
This is Rietveld 408576698