Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: src/profiler/sampler.h

Issue 1752173003: Additional fixes for external callback logging in profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix test-log-stack-tracer.cc Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/sampler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PROFILER_SAMPLER_H_ 5 #ifndef V8_PROFILER_SAMPLER_H_
6 #define V8_PROFILER_SAMPLER_H_ 6 #define V8_PROFILER_SAMPLER_H_
7 7
8 #include "include/v8.h" 8 #include "include/v8.h"
9 9
10 #include "src/base/atomicops.h" 10 #include "src/base/atomicops.h"
(...skipping 16 matching lines...) Expand all
27 // TickSample captures the information collected for each sample. 27 // TickSample captures the information collected for each sample.
28 struct TickSample { 28 struct TickSample {
29 // Internal profiling (with --prof + tools/$OS-tick-processor) wants to 29 // Internal profiling (with --prof + tools/$OS-tick-processor) wants to
30 // include the runtime function we're calling. Externally exposed tick 30 // include the runtime function we're calling. Externally exposed tick
31 // samples don't care. 31 // samples don't care.
32 enum RecordCEntryFrame { kIncludeCEntryFrame, kSkipCEntryFrame }; 32 enum RecordCEntryFrame { kIncludeCEntryFrame, kSkipCEntryFrame };
33 33
34 TickSample() 34 TickSample()
35 : state(OTHER), 35 : state(OTHER),
36 pc(NULL), 36 pc(NULL),
37 external_callback(NULL), 37 external_callback_entry(NULL),
38 frames_count(0), 38 frames_count(0),
39 has_external_callback(false), 39 has_external_callback(false),
40 update_stats(true), 40 update_stats(true),
41 top_frame_type(StackFrame::NONE) {} 41 top_frame_type(StackFrame::NONE) {}
42 void Init(Isolate* isolate, const v8::RegisterState& state, 42 void Init(Isolate* isolate, const v8::RegisterState& state,
43 RecordCEntryFrame record_c_entry_frame, bool update_stats); 43 RecordCEntryFrame record_c_entry_frame, bool update_stats);
44 static void GetStackSample(Isolate* isolate, const v8::RegisterState& state, 44 static void GetStackSample(Isolate* isolate, const v8::RegisterState& state,
45 RecordCEntryFrame record_c_entry_frame, 45 RecordCEntryFrame record_c_entry_frame,
46 void** frames, size_t frames_limit, 46 void** frames, size_t frames_limit,
47 v8::SampleInfo* sample_info); 47 v8::SampleInfo* sample_info);
48 StateTag state; // The state of the VM. 48 StateTag state; // The state of the VM.
49 Address pc; // Instruction pointer. 49 Address pc; // Instruction pointer.
50 union { 50 union {
51 Address tos; // Top stack value (*sp). 51 Address tos; // Top stack value (*sp).
52 Address external_callback; 52 Address external_callback_entry;
53 }; 53 };
54 static const unsigned kMaxFramesCountLog2 = 8; 54 static const unsigned kMaxFramesCountLog2 = 8;
55 static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1; 55 static const unsigned kMaxFramesCount = (1 << kMaxFramesCountLog2) - 1;
56 Address stack[kMaxFramesCount]; // Call stack. 56 Address stack[kMaxFramesCount]; // Call stack.
57 base::TimeTicks timestamp; 57 base::TimeTicks timestamp;
58 unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames. 58 unsigned frames_count : kMaxFramesCountLog2; // Number of captured frames.
59 bool has_external_callback : 1; 59 bool has_external_callback : 1;
60 bool update_stats : 1; // Whether the sample should update aggregated stats. 60 bool update_stats : 1; // Whether the sample should update aggregated stats.
61 StackFrame::Type top_frame_type : 4; 61 StackFrame::Type top_frame_type : 4;
62 }; 62 };
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 unsigned js_sample_count_; 130 unsigned js_sample_count_;
131 unsigned external_sample_count_; 131 unsigned external_sample_count_;
132 DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler); 132 DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
133 }; 133 };
134 134
135 135
136 } // namespace internal 136 } // namespace internal
137 } // namespace v8 137 } // namespace v8
138 138
139 #endif // V8_PROFILER_SAMPLER_H_ 139 #endif // V8_PROFILER_SAMPLER_H_
OLDNEW
« no previous file with comments | « src/profiler/profile-generator.cc ('k') | src/profiler/sampler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698