Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Issue 1752173003: Additional fixes for external callback logging in profiler. (Closed)

Created:
4 years, 9 months ago by MTBrandyberry
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Additional fixes for external callback logging in profiler. For platforms that use function descriptors (currently AIX and PPC64BE), log an external callback's entrypoint address rather than its function descriptor address. R=jkummerow@chromium.org, michael_dawson@ca.ibm.com TEST=cctest/test-cpu-profiler/JsNativeJsSample BUG= Committed: https://crrev.com/9f8c21164c9ed3af4fdfac4f062b1a032c167b6e Cr-Commit-Position: refs/heads/master@{#34505}

Patch Set 1 #

Patch Set 2 : Fix test-log-stack-tracer.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -15 lines) Patch
M src/log.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M src/profiler/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/profiler/sampler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/profiler/sampler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-log.cc View 2 chunks +20 lines, -4 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752173003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752173003/1
4 years, 9 months ago (2016-03-02 17:11:25 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10968) v8_linux64_rel_ng on ...
4 years, 9 months ago (2016-03-02 17:14:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752173003/20001
4 years, 9 months ago (2016-03-02 18:11:36 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/10973)
4 years, 9 months ago (2016-03-02 18:16:27 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752173003/20001
4 years, 9 months ago (2016-03-02 19:19:30 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-02 19:29:19 UTC) #12
MTBrandyberry
PTAL
4 years, 9 months ago (2016-03-02 19:34:27 UTC) #13
michael_dawson
On 2016/03/02 19:34:27, MTBrandyberry wrote: > PTAL lgtm from the power side of things.
4 years, 9 months ago (2016-03-02 19:47:10 UTC) #14
michael_dawson
On 2016/03/02 19:34:27, MTBrandyberry wrote: > PTAL lgtm from the power side of things.
4 years, 9 months ago (2016-03-02 19:47:13 UTC) #15
MTBrandyberry
On 2016/03/02 19:47:13, michael_dawson wrote: > On 2016/03/02 19:34:27, MTBrandyberry wrote: > > PTAL > ...
4 years, 9 months ago (2016-03-04 17:04:26 UTC) #16
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-04 18:29:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752173003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752173003/20001
4 years, 9 months ago (2016-03-04 18:35:00 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 18:55:53 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 18:57:37 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f8c21164c9ed3af4fdfac4f062b1a032c167b6e
Cr-Commit-Position: refs/heads/master@{#34505}

Powered by Google App Engine
This is Rietveld 408576698